Issue 223873003: Revert r20476.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 223873003: Revert r20476. (Closed)

Created:
6 years, 8 months ago by jochen (gone - plz use gerrit)

Modified:
6 years, 8 months ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Revert r20476. Reason for revert: crashes arm64.debug cctest Fatal error in ../src/hydrogen-instructions.h, line 2968 CHECK(value->IsCheckHeapObject()) failed Fixed environment assignment for LCheckNonSmi. TBR=svenpanne@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=20484

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -12 lines)			Patch
M	src/arm/lithium-arm.cc	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	src/arm64/lithium-arm64.cc	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	src/ia32/lithium-ia32.cc	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	src/x64/lithium-x64.cc	View	1 chunk	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jochen (gone - plz use gerrit)

6 years, 8 months ago (2014-04-03 14:04:12 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r20484 (tree was closed).

Expand Messages | Collapse Messages