Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2238703002:
chromeos: Avoid org.neard.Manager D-Bus log spam. (Closed)
|
Created:
4 years, 4 months ago by Daniel Erat Modified:
4 years, 4 months ago CC:
chromium-reviews, oshima+watch_chromium.org, hashimoto+watch_chromium.org, armansito Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptionchromeos: Avoid org.neard.Manager D-Bus log spam.
Make NfcManagerClientImpl defer making its initial call to
get neard's properties until D-Bus has notified Chrome that
neard is available.
BUG=636554
TBR=stevenjb@chromium.org
Committed: https://crrev.com/66e73f0329fbc2953bcc65d07d548a00441e625c
Cr-Commit-Position: refs/heads/master@{#413743}
Patch Set 1 #Patch Set 2 : oh, gmock #
Messages
Total messages: 25 (16 generated)
derat@chromium.org changed reviewers: + stevenjb@chromium.org
i'm not sure about how to test this code (neard doesn't get started on any of my devices, i don't think), or even of where it's used -- i don't see the "nfc" USE flag, which looks like the thing that pulls in the neard package, set on any boards. this stops the spam, though. :-P
The CQ bit was checked by derat@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
stevenjb@chromium.org changed reviewers: + armansito@chromium.org
I don't know either. amransito@, does this look OK to you? Do you know what device(s) we can test this on?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by derat@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm. I don't think NFC has ever been enabled on any device, so I wouldn't worry about breaking anything.
The CQ bit was checked by derat@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
Description was changed from ========== chromeos: Avoid org.neard.Manager D-Bus log spam. Make NfcManagerClientImpl defer making its initial call to get neard's properties until D-Bus has notified Chrome that neard is available. BUG=636554 ========== to ========== chromeos: Avoid org.neard.Manager D-Bus log spam. Make NfcManagerClientImpl defer making its initial call to get neard's properties until D-Bus has notified Chrome that neard is available. BUG=636554 TBR=stevenjb@chromium.org ==========
TBR-ing steven for additional method in dbus/ mock header
The CQ bit was checked by derat@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== chromeos: Avoid org.neard.Manager D-Bus log spam. Make NfcManagerClientImpl defer making its initial call to get neard's properties until D-Bus has notified Chrome that neard is available. BUG=636554 TBR=stevenjb@chromium.org ========== to ========== chromeos: Avoid org.neard.Manager D-Bus log spam. Make NfcManagerClientImpl defer making its initial call to get neard's properties until D-Bus has notified Chrome that neard is available. BUG=636554 TBR=stevenjb@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== chromeos: Avoid org.neard.Manager D-Bus log spam. Make NfcManagerClientImpl defer making its initial call to get neard's properties until D-Bus has notified Chrome that neard is available. BUG=636554 TBR=stevenjb@chromium.org ========== to ========== chromeos: Avoid org.neard.Manager D-Bus log spam. Make NfcManagerClientImpl defer making its initial call to get neard's properties until D-Bus has notified Chrome that neard is available. BUG=636554 TBR=stevenjb@chromium.org Committed: https://crrev.com/66e73f0329fbc2953bcc65d07d548a00441e625c Cr-Commit-Position: refs/heads/master@{#413743} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/66e73f0329fbc2953bcc65d07d548a00441e625c Cr-Commit-Position: refs/heads/master@{#413743} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
