Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Unified Diff: ui/compositor/test/in_process_context_factory.h

Issue 2238693002: Plumb SetVisible from ui::Compositor to the DirectRenderer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: setvisible-browser: . Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/compositor/test/in_process_context_factory.h
diff --git a/ui/compositor/test/in_process_context_factory.h b/ui/compositor/test/in_process_context_factory.h
index d17e148b8903b2f556ce61a5d09b5f2cbc164b83..656f61c22d2546f2e7f862e927658f90a02ad8fd 100644
--- a/ui/compositor/test/in_process_context_factory.h
+++ b/ui/compositor/test/in_process_context_factory.h
@@ -62,6 +62,7 @@ class InProcessContextFactory : public ContextFactory {
cc::TaskGraphRunner* GetTaskGraphRunner() override;
uint32_t AllocateSurfaceClientId() override;
cc::SurfaceManager* GetSurfaceManager() override;
+ void SetDisplayVisible(ui::Compositor* compositor, bool visible) override;
void ResizeDisplay(ui::Compositor* compositor,
const gfx::Size& size) override;
void SetDisplayColorSpace(ui::Compositor* compositor,
@@ -88,8 +89,17 @@ class InProcessContextFactory : public ContextFactory {
cc::SurfaceManager* surface_manager_;
base::ObserverList<ContextFactoryObserver> observer_list_;
- base::hash_map<Compositor*, std::unique_ptr<cc::Display>>
- per_compositor_data_;
+ struct PerCompositorData {
+ PerCompositorData();
+ ~PerCompositorData();
+
+ PerCompositorData(PerCompositorData&&);
+ PerCompositorData& operator=(PerCompositorData&&);
+
+ bool visible;
sunnyps 2016/08/15 23:20:03 I think you should initialize visible here? (and m
danakj 2016/08/16 00:37:22 Oh, yes I should! But actually I looked at this a
+ std::unique_ptr<cc::Display> display;
+ };
+ base::hash_map<Compositor*, PerCompositorData> per_compositor_data_;
DISALLOW_COPY_AND_ASSIGN(InProcessContextFactory);
};

Powered by Google App Engine
This is Rietveld 408576698