Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2666)

Unified Diff: cc/output/gl_renderer_unittest.cc

Issue 2238693002: Plumb SetVisible from ui::Compositor to the DirectRenderer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: setvisible-browser: . Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/output/gl_renderer_unittest.cc
diff --git a/cc/output/gl_renderer_unittest.cc b/cc/output/gl_renderer_unittest.cc
index b461c21a3684590931ebe7db8f50e30f13747547..5a18c722410e06396e618ffae92b6fc71e4240e0 100644
--- a/cc/output/gl_renderer_unittest.cc
+++ b/cc/output/gl_renderer_unittest.cc
@@ -365,6 +365,7 @@ class GLRendererWithDefaultHarnessTest : public GLRendererTest {
renderer_ = base::WrapUnique(
new FakeRendererGL(&renderer_client_, &settings_, output_surface_.get(),
resource_provider_.get()));
+ renderer_->SetVisible(true);
}
void SwapBuffers() { renderer_->SwapBuffers(CompositorFrameMetadata()); }
@@ -396,6 +397,7 @@ class GLRendererShaderTest : public GLRendererTest {
&settings_,
output_surface_.get(),
resource_provider_.get()));
+ renderer_->SetVisible(true);
}
void TestRenderPassProgram(TexCoordPrecision precision,
@@ -761,6 +763,7 @@ TEST_F(GLRendererTest, OpaqueBackground) {
&settings,
output_surface.get(),
resource_provider.get());
+ renderer.SetVisible(true);
gfx::Rect viewport_rect(1, 1);
RenderPass* root_pass =
@@ -803,6 +806,7 @@ TEST_F(GLRendererTest, TransparentBackground) {
&settings,
output_surface.get(),
resource_provider.get());
+ renderer.SetVisible(true);
gfx::Rect viewport_rect(1, 1);
RenderPass* root_pass =
@@ -838,6 +842,7 @@ TEST_F(GLRendererTest, OffscreenOutputSurface) {
&settings,
output_surface.get(),
resource_provider.get());
+ renderer.SetVisible(true);
gfx::Rect viewport_rect(1, 1);
AddRenderPass(&render_passes_in_draw_order_,
@@ -897,6 +902,7 @@ TEST_F(GLRendererTest, ActiveTextureState) {
&settings,
output_surface.get(),
resource_provider.get());
+ renderer.SetVisible(true);
// During initialization we are allowed to set any texture parameters.
EXPECT_CALL(*context, texParameteri(_, _, _)).Times(AnyNumber());
@@ -981,6 +987,7 @@ TEST_F(GLRendererTest, ShouldClearRootRenderPass) {
&settings,
output_surface.get(),
resource_provider.get());
+ renderer.SetVisible(true);
gfx::Rect viewport_rect(10, 10);
@@ -1067,6 +1074,7 @@ TEST_F(GLRendererTest, ScissorTestWhenClearing) {
output_surface.get(),
resource_provider.get());
EXPECT_FALSE(renderer.Capabilities().using_partial_swap);
+ renderer.SetVisible(true);
gfx::Rect viewport_rect(1, 1);
@@ -1158,6 +1166,7 @@ TEST_F(GLRendererTest, NoDiscardOnPartialUpdates) {
output_surface.get(),
resource_provider.get());
EXPECT_TRUE(renderer.Capabilities().using_partial_swap);
+ renderer.SetVisible(true);
gfx::Rect viewport_rect(100, 100);
gfx::Rect clip_rect(100, 100);
@@ -1292,6 +1301,7 @@ TEST_F(GLRendererTest, ScissorAndViewportWithinNonreshapableSurface) {
output_surface.get(),
resource_provider.get());
EXPECT_FALSE(renderer.Capabilities().using_partial_swap);
+ renderer.SetVisible(true);
gfx::Rect device_viewport_rect(10, 10, 100, 100);
gfx::Rect viewport_rect(device_viewport_rect.size());
@@ -1329,6 +1339,7 @@ TEST_F(GLRendererTest, DrawFramePreservesFramebuffer) {
FakeRendererGL renderer(&renderer_client, &settings, output_surface.get(),
resource_provider.get());
EXPECT_FALSE(renderer.Capabilities().using_partial_swap);
+ renderer.SetVisible(true);
gfx::Rect device_viewport_rect(0, 0, 100, 100);
gfx::Rect viewport_rect(device_viewport_rect.size());
@@ -1712,6 +1723,7 @@ class MockOutputSurfaceTest : public GLRendererTest {
&settings_,
&output_surface_,
resource_provider_.get()));
+ renderer_->SetVisible(true);
}
void SwapBuffers() { renderer_->SwapBuffers(CompositorFrameMetadata()); }
@@ -1861,6 +1873,7 @@ TEST_F(GLRendererTest, DontOverlayWithCopyRequests) {
FakeRendererClient renderer_client;
FakeRendererGL renderer(&renderer_client, &settings, output_surface.get(),
resource_provider.get(), mailbox_deleter.get());
+ renderer.SetVisible(true);
TestOverlayProcessor* processor =
new TestOverlayProcessor(output_surface.get());
@@ -2019,6 +2032,7 @@ TEST_F(GLRendererTest, OverlaySyncTokensAreProcessed) {
FakeRendererClient renderer_client;
FakeRendererGL renderer(&renderer_client, &settings, output_surface.get(),
resource_provider.get(), mailbox_deleter.get());
+ renderer.SetVisible(true);
SingleOverlayOnTopProcessor* processor =
new SingleOverlayOnTopProcessor(output_surface.get());
@@ -2098,6 +2112,7 @@ class GLRendererPartialSwapTest : public GLRendererTest {
FakeRendererGL renderer(&renderer_client, &settings, output_surface.get(),
resource_provider.get());
EXPECT_EQ(partial_swap, renderer.Capabilities().using_partial_swap);
+ renderer.SetVisible(true);
gfx::Rect viewport_rect(100, 100);
gfx::Rect clip_rect(100, 100);

Powered by Google App Engine
This is Rietveld 408576698