Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 2238633003: Revert renderer IPC::Channel acquisition via shell connection (Closed)

Created:
4 years, 4 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 4 months ago
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, nasko+codewatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert renderer IPC::Channel acquisition via shell connection This may be causing failures in some test environments. Reverting for now until there's more time to investigate. This CL effectively reverts a subset of ff1b853cb6bfc3d5402fc970b2d856cbe73418cc. BUG=636624 TBR=ben@chromium.org Committed: https://crrev.com/fd446c5a79522af111bb141559132893d85b60f8 Cr-Commit-Position: refs/heads/master@{#411234}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -5 lines) Patch
M content/browser/renderer_host/render_process_host_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 3 chunks +10 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2238633003/20001
4 years, 4 months ago (2016-08-11 01:17:09 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-11 02:50:45 UTC) #10
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/fd446c5a79522af111bb141559132893d85b60f8 Cr-Commit-Position: refs/heads/master@{#411234}
4 years, 4 months ago (2016-08-11 02:52:06 UTC) #12
Ken Rockot(use gerrit already)
4 years, 4 months ago (2016-08-11 17:53:28 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2243533002/ by rockot@chromium.org.

The reason for reverting is: Essentially relanding the new bootstrap behavior
since it apparently wasn't the cause of breakage..

Powered by Google App Engine
This is Rietveld 408576698