Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2238633002:
MD User Manager: add back i18n processing in JS (Closed)
|
Created:
4 years, 4 months ago by Dan Beam Modified:
4 years, 4 months ago Reviewers:
tommycli CC:
chromium-reviews, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMD User Manager: add back i18n processing in JS
There was a whole bunch more i18n-content inside of ui/login that is
used by the MD user manager (whoops!).
This is a partial revert of crrev.com/410750
R=tommycli@chromium.org
BUG=636244
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/4926894a3c485b7a839ae803a4269cfc4db3df80
Cr-Commit-Position: refs/heads/master@{#411244}
Patch Set 1 #
Messages
Total messages: 17 (8 generated)
Description was changed from ========== MD User Manager: add back i18n processing in JS There was a whole bunch more i18n-content inside of ui/login that is used by the MD user manager (whoops!). This is a partial revert of crrev.com/410750 R=tommycli@chromium.org BUG=636244 ========== to ========== MD User Manager: add back i18n processing in JS There was a whole bunch more i18n-content inside of ui/login that is used by the MD user manager (whoops!). This is a partial revert of crrev.com/410750 R=tommycli@chromium.org BUG=636244 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by dbeam@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2016/08/10 21:13:31, Dan Beam wrote: Should those ui/login files themselves include i18n_template then?
On 2016/08/10 21:28:43, tommycli wrote:
> On 2016/08/10 21:13:31, Dan Beam wrote:
>
> Should those ui/login files themselves include i18n_template then?
probably. i just know this fixes now without negative side effects because it's
basically a revert.
i don't really understand how the user manager re-uses chromeos code. it's all
voodoo. i thought about just updating those files in ui/login that have
i18n-content to $i18n{} but thought i'd probably just break more things.
if you don't like this fix i can just revert the whole issue instead.
On 2016/08/10 21:41:39, Dan Beam wrote:
> On 2016/08/10 21:28:43, tommycli wrote:
> > On 2016/08/10 21:13:31, Dan Beam wrote:
> >
> > Should those ui/login files themselves include i18n_template then?
>
> probably. i just know this fixes now without negative side effects because
it's
> basically a revert.
>
> i don't really understand how the user manager re-uses chromeos code. it's
all
> voodoo. i thought about just updating those files in ui/login that have
> i18n-content to $i18n{} but thought i'd probably just break more things.
>
> if you don't like this fix i can just revert the whole issue instead.
partial revert is fine. lgtm
The CQ bit was unchecked by dbeam@chromium.org
The CQ bit was checked by dbeam@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by dbeam@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== MD User Manager: add back i18n processing in JS There was a whole bunch more i18n-content inside of ui/login that is used by the MD user manager (whoops!). This is a partial revert of crrev.com/410750 R=tommycli@chromium.org BUG=636244 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== MD User Manager: add back i18n processing in JS There was a whole bunch more i18n-content inside of ui/login that is used by the MD user manager (whoops!). This is a partial revert of crrev.com/410750 R=tommycli@chromium.org BUG=636244 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/4926894a3c485b7a839ae803a4269cfc4db3df80 Cr-Commit-Position: refs/heads/master@{#411244} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/4926894a3c485b7a839ae803a4269cfc4db3df80 Cr-Commit-Position: refs/heads/master@{#411244} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
