chrome/renderer/extensions/automation_internal_custom_bindings.cc - Issue 2238613002: Support output for Chrome's native find in ChromeVox.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/extensions/automation_internal_custom_bindings.cc

Issue 2238613002: Support output for Chrome's native find in ChromeVox. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@text_markers

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/chromeos/chromevox/cvox2/background/find_handler.js ('K') | « chrome/common/extensions/api/automation.idl ('k') | third_party/WebKit/Source/web/TextFinder.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/extensions/automation_internal_custom_bindings.cc

diff --git a/chrome/renderer/extensions/automation_internal_custom_bindings.cc b/chrome/renderer/extensions/automation_internal_custom_bindings.cc

index ad12627f32dc6cf6cfbd84b8659ea17ea46bcb6c..6aeb9cd08bc183afe2b44ac4f55a213d7f46298e 100644

--- a/chrome/renderer/extensions/automation_internal_custom_bindings.cc

+++ b/chrome/renderer/extensions/automation_internal_custom_bindings.cc

@@ -1217,6 +1217,10 @@ void AutomationInternalCustomBindings::SendTreeChangeEvent(

return;

}

break;

+ case api::automation::TREE_CHANGE_OBSERVER_FILTER_TEXTMARKERCHANGES:

+ if (!node->data().HasIntListAttribute(ui::AX_ATTR_MARKER_TYPES))

+ return;

+ break;

case api::automation::TREE_CHANGE_OBSERVER_FILTER_ALLTREECHANGES:

break;

}

@@ -1243,6 +1247,10 @@ void AutomationInternalCustomBindings::SendTreeChangeEvent(

continue;

}

break;

+ case api::automation::TREE_CHANGE_OBSERVER_FILTER_TEXTMARKERCHANGES:

+ if (!node->data().HasIntListAttribute(ui::AX_ATTR_MARKER_TYPES))

+ continue;

+ break;

case api::automation::TREE_CHANGE_OBSERVER_FILTER_ALLTREECHANGES:

break;

}