Support output for Chrome's native find in ChromeVox.

Support output for Chrome's native find in ChromeVox.

The i-search impl currently suffers from two major problems:
- performance: asking each node for its name causes a context change from js to native and back; on a large site it was taking on the order of minutes to hear the next search result
- walking the automation tree while the find dialog is up often times causes ndoes to be detached

This cl makes it so:
- ctrl+f search read out properly and sync ChromeVox's cursor
- actual system focus remains on the find dialog
- the user would need to press escape to continue navigation from the search hit

BUG=635381
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/dcf3ed28c3ad8a341f3319e425474016ac9904d5
Cr-Commit-Position: refs/heads/master@{#412239}

[David Tseng, 2016-08-10 21:01:52]

Description was changed from

==========
Support output for Chrome's native find in ChromeVox.
==========

to

==========
Support output for Chrome's native find in ChromeVox.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2016-08-10 21:05:20]

Description was changed from

==========
Support output for Chrome's native find in ChromeVox.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Support output for Chrome's native find in ChromeVox.

The i-search impl currently suffers from two major problems:
- performance: asking each node for its name causes a context change from js to
native and back; on a large site it was taking on the order of minutes to hear
the next search result
- walking the automation tree while the find dialog is up often times causes
ndoes to be detached

This cl makes it so:
- ctrl+f search read out properly and sync ChromeVox's cursor
- actual system focus remains on the find dialog
- the user would need to press escape to continue navigation from the search hit

BUG=635381
==========

[David Tseng, 2016-08-10 21:05:20]

dtseng@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[dmazzoni, 2016-08-10 22:12:10]

Please look into what happens when there are multiple matches

https://codereview.chromium.org/2238613002/diff/1/chrome/browser/resources/ch...
File
chrome/browser/resources/chromeos/chromevox/cvox2/background/find_handler.js
(right):

https://codereview.chromium.org/2238613002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/chromevox/cvox2/background/find_handler.js:52:
var range = cursors.Range.fromNode(evt.target);
Does this work if there are multiple matches?

[dmazzoni, 2016-08-10 22:40:28]

OK, I see now that this should work because a change to the tree that adds
a text marker will basically only happen for the current one.

However, it's a bit brittle because technically there should be text markers
for all potential matches and we ought to have a separate event for the
current one.

Maybe add a TODO?

I'd like it if we plumb through the find results. I think we need a
way to attach extra attributes to AXEvents, that would help

[dmazzoni, 2016-08-10 22:43:15]

lgtm if you're convinced this works when there are multiple find results

[David Tseng, 2016-08-11 19:15:19]

Description was changed from

==========
Support output for Chrome's native find in ChromeVox.

The i-search impl currently suffers from two major problems:
- performance: asking each node for its name causes a context change from js to
native and back; on a large site it was taking on the order of minutes to hear
the next search result
- walking the automation tree while the find dialog is up often times causes
ndoes to be detached

This cl makes it so:
- ctrl+f search read out properly and sync ChromeVox's cursor
- actual system focus remains on the find dialog
- the user would need to press escape to continue navigation from the search hit

BUG=635381
==========

to

==========
Support output for Chrome's native find in ChromeVox.

The i-search impl currently suffers from two major problems:
- performance: asking each node for its name causes a context change from js to
native and back; on a large site it was taking on the order of minutes to hear
the next search result
- walking the automation tree while the find dialog is up often times causes
ndoes to be detached

This cl makes it so:
- ctrl+f search read out properly and sync ChromeVox's cursor
- actual system focus remains on the find dialog
- the user would need to press escape to continue navigation from the search hit

BUG=635381
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2016-08-11 19:17:36]

dtseng@chromium.org changed reviewers:
+ pfeldman@chromium.org

[David Tseng, 2016-08-11 19:17:37]

+ pfeldman for TextFinder.cpp

I did verify that the active range gets reported as I went through search
results via the enter key.

[David Tseng, 2016-08-11 19:17:47]

The CQ bit was checked by dtseng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-11 19:18:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 20:37:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-11 20:37:04]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[David Tseng, 2016-08-12 19:04:43]

The CQ bit was checked by dtseng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-12 19:05:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 19:51:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-12 19:51:11]

Dry run: Exceeded global retry quota

[David Tseng, 2016-08-12 19:59:23]

The CQ bit was checked by dtseng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-12 19:59:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 20:03:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-12 20:03:46]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[pfeldman, 2016-08-13 00:15:56]

lgtm as long as dmazzoni likes it.

[David Tseng, 2016-08-13 04:26:12]

The CQ bit was checked by dtseng@chromium.org

[David Tseng, 2016-08-13 04:26:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/2238613002/#ps40001
(title: "Make tree_change_observer_overall_filter_ into a bitmap")

[commit-bot: I haz the power, 2016-08-13 04:26:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-13 04:29:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-13 04:29:13]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[David Tseng, 2016-08-15 19:22:57]

The CQ bit was checked by dtseng@chromium.org

[David Tseng, 2016-08-15 19:22:58]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org, pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/2238613002/#ps60001
(title: "Rebase (after chromevox.gni removed and ax_enums.idl changes).")

[commit-bot: I haz the power, 2016-08-15 19:23:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-15 20:13:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-15 20:13:34]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[David Tseng, 2016-08-15 22:31:10]

The CQ bit was checked by dtseng@chromium.org

[David Tseng, 2016-08-15 22:31:10]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org, pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/2238613002/#ps80001
(title: "Fix bug in RemoveTreeChangeObserver.")

[commit-bot: I haz the power, 2016-08-15 22:31:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-15 23:21:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-15 23:21:49]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[David Tseng, 2016-08-16 01:42:31]

The CQ bit was checked by dtseng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-16 01:42:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-16 03:01:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-16 03:01:57]

Dry run: This issue passed the CQ dry run.

[David Tseng, 2016-08-16 15:11:52]

The CQ bit was checked by dtseng@chromium.org

[David Tseng, 2016-08-16 15:11:53]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org, pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/2238613002/#ps100001
(title: "Don't forget to bit shift in SendTreeChanges (checking against cached
overall tree filter).")

[commit-bot: I haz the power, 2016-08-16 15:12:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-16 15:15:39]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-08-16 15:18:07]

Description was changed from

==========
Support output for Chrome's native find in ChromeVox.

The i-search impl currently suffers from two major problems:
- performance: asking each node for its name causes a context change from js to
native and back; on a large site it was taking on the order of minutes to hear
the next search result
- walking the automation tree while the find dialog is up often times causes
ndoes to be detached

This cl makes it so:
- ctrl+f search read out properly and sync ChromeVox's cursor
- actual system focus remains on the find dialog
- the user would need to press escape to continue navigation from the search hit

BUG=635381
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Support output for Chrome's native find in ChromeVox.

The i-search impl currently suffers from two major problems:
- performance: asking each node for its name causes a context change from js to
native and back; on a large site it was taking on the order of minutes to hear
the next search result
- walking the automation tree while the find dialog is up often times causes
ndoes to be detached

This cl makes it so:
- ctrl+f search read out properly and sync ChromeVox's cursor
- actual system focus remains on the find dialog
- the user would need to press escape to continue navigation from the search hit

BUG=635381
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/dcf3ed28c3ad8a341f3319e425474016ac9904d5
Cr-Commit-Position: refs/heads/master@{#412239}
==========

[commit-bot: I haz the power, 2016-08-16 15:18:09]

Patchset 6 (id:??) landed as
https://crrev.com/dcf3ed28c3ad8a341f3319e425474016ac9904d5
Cr-Commit-Position: refs/heads/master@{#412239}