Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 2238583002: Enable code signature for Cronet.framework. (Closed)

Created:
4 years, 4 months ago by sdefresne
Modified:
4 years, 4 months ago
Reviewers:
justincohen
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable code signature for Cronet.framework. The underlying issue that cause the code signature to fail for Cronet.framework was fixed with http://crrev.com/2233663002/ & http://crrev.com/2231723002/. BUG=None Committed: https://crrev.com/95e03563d71116d3a85a5108509e7eb87cb04cf3 Cr-Commit-Position: refs/heads/master@{#411277}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M components/cronet/ios/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
sdefresne
Please take a look.
4 years, 4 months ago (2016-08-10 20:36:57 UTC) #3
justincohen
Can we keep the ability to disable code signing, e.g. enable_code_signing, just incase we need ...
4 years, 4 months ago (2016-08-10 20:38:43 UTC) #5
sdefresne
On 2016/08/10 20:38:43, justincohen wrote: > Can we keep the ability to disable code signing, ...
4 years, 4 months ago (2016-08-10 20:42:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2238583002/1
4 years, 4 months ago (2016-08-11 06:09:04 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-11 06:12:27 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-11 06:14:20 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/95e03563d71116d3a85a5108509e7eb87cb04cf3
Cr-Commit-Position: refs/heads/master@{#411277}

Powered by Google App Engine
This is Rietveld 408576698