Fix 4444 on Vulkan devices who don't support RGBA_4444

Fix 4444 on Vulkan devices who don't support RGBA_4444

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2238563002

Committed: https://skia.googlesource.com/skia/+/637b3bf2b9c10398d823bd015a722842d4f2f971
Committed: https://skia.googlesource.com/skia/+/3fe0327585f32ea2b9334965d8c90d9d699c584e

[egdaniel, 2016-08-10 18:31:13]

Description was changed from

==========
Fix 4444 on Vulkan devices who don't support RGBA_4444

BUG=skia:
==========

to

==========
Fix 4444 on Vulkan devices who don't support RGBA_4444

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2238563002
==========

[egdaniel, 2016-08-10 18:35:42]

egdaniel@google.com changed reviewers:
+ bsalomon@google.com

[egdaniel, 2016-08-11 17:23:16]

On 2016/08/10 18:35:42, egdaniel wrote:

ping

[bsalomon, 2016-08-11 18:02:08]

lgtm w/ request for some comments

https://codereview.chromium.org/2238563002/diff/40001/src/gpu/vk/GrVkCaps.cpp
File src/gpu/vk/GrVkCaps.cpp (right):

https://codereview.chromium.org/2238563002/diff/40001/src/gpu/vk/GrVkCaps.cpp...
src/gpu/vk/GrVkCaps.cpp:140: if (kRGBA_4444_GrPixelConfig == config) {
Maybe a comment here about why?

https://codereview.chromium.org/2238563002/diff/40001/src/gpu/vk/GrVkUtil.cpp
File src/gpu/vk/GrVkUtil.cpp (right):

https://codereview.chromium.org/2238563002/diff/40001/src/gpu/vk/GrVkUtil.cpp...
src/gpu/vk/GrVkUtil.cpp:33: *format = VK_FORMAT_B4G4R4A4_UNORM_PACK16;
comment?

https://codereview.chromium.org/2238563002/diff/40001/src/gpu/vk/GrVkUtil.cpp...
src/gpu/vk/GrVkUtil.cpp:91: case VK_FORMAT_B4G4R4A4_UNORM_PACK16:
comment?

[egdaniel, 2016-08-11 20:09:15]

https://codereview.chromium.org/2238563002/diff/40001/src/gpu/vk/GrVkCaps.cpp
File src/gpu/vk/GrVkCaps.cpp (right):

https://codereview.chromium.org/2238563002/diff/40001/src/gpu/vk/GrVkCaps.cpp...
src/gpu/vk/GrVkCaps.cpp:140: if (kRGBA_4444_GrPixelConfig == config) {
On 2016/08/11 18:02:08, bsalomon wrote:
> Maybe a comment here about why?

Done.

https://codereview.chromium.org/2238563002/diff/40001/src/gpu/vk/GrVkUtil.cpp
File src/gpu/vk/GrVkUtil.cpp (right):

https://codereview.chromium.org/2238563002/diff/40001/src/gpu/vk/GrVkUtil.cpp...
src/gpu/vk/GrVkUtil.cpp:33: *format = VK_FORMAT_B4G4R4A4_UNORM_PACK16;
On 2016/08/11 18:02:08, bsalomon wrote:
> comment?

Done.

https://codereview.chromium.org/2238563002/diff/40001/src/gpu/vk/GrVkUtil.cpp...
src/gpu/vk/GrVkUtil.cpp:91: case VK_FORMAT_B4G4R4A4_UNORM_PACK16:
On 2016/08/11 18:02:08, bsalomon wrote:
> comment?

Done.

[egdaniel, 2016-08-11 20:09:19]

The CQ bit was checked by egdaniel@google.com

[egdaniel, 2016-08-11 20:09:19]

The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com
Link to the patchset: https://codereview.chromium.org/2238563002/#ps60001
(title: "Add comments")

[commit-bot: I haz the power, 2016-08-11 20:09:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 20:44:26]

Description was changed from

==========
Fix 4444 on Vulkan devices who don't support RGBA_4444

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2238563002
==========

to

==========
Fix 4444 on Vulkan devices who don't support RGBA_4444

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2238563002

Committed:
https://skia.googlesource.com/skia/+/637b3bf2b9c10398d823bd015a722842d4f2f971
==========

[commit-bot: I haz the power, 2016-08-11 20:44:27]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/637b3bf2b9c10398d823bd015a722842d4f2f971

[egdaniel, 2016-08-11 23:17:25]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2240713003/ by egdaniel@google.com.

The reason for reverting is: test failing on some gpus.

[egdaniel, 2016-08-12 17:16:31]

Description was changed from

==========
Fix 4444 on Vulkan devices who don't support RGBA_4444

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2238563002

Committed:
https://skia.googlesource.com/skia/+/637b3bf2b9c10398d823bd015a722842d4f2f971
==========

to

==========
Fix 4444 on Vulkan devices who don't support RGBA_4444

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2238563002

Committed:
https://skia.googlesource.com/skia/+/637b3bf2b9c10398d823bd015a722842d4f2f971
==========

[egdaniel, 2016-08-12 17:17:54]

Updated to read back into an 8888 buffer

[egdaniel, 2016-08-12 17:53:41]

The CQ bit was checked by egdaniel@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-12 17:53:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 18:49:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-12 18:49:43]

Dry run: This issue passed the CQ dry run.

[egdaniel, 2016-08-15 14:50:45]

ptal at the changes

[bsalomon, 2016-08-15 16:24:08]

comment about comment, otherwise lgtm.

https://codereview.chromium.org/2238563002/diff/80001/src/gpu/GrGpu.cpp
File src/gpu/GrGpu.cpp (right):

https://codereview.chromium.org/2238563002/diff/80001/src/gpu/GrGpu.cpp#newco...
src/gpu/GrGpu.cpp:281: // required to be renderable formats on all backends.
I don't know that the fundamental problem is renderability. ES 3.2 does require
they're renderable, but it still doesn't guarantee support that they can be
read. The real problem is that you can't use them as a read back format.

[egdaniel, 2016-08-15 17:03:01]

https://codereview.chromium.org/2238563002/diff/80001/src/gpu/GrGpu.cpp
File src/gpu/GrGpu.cpp (right):

https://codereview.chromium.org/2238563002/diff/80001/src/gpu/GrGpu.cpp#newco...
src/gpu/GrGpu.cpp:281: // required to be renderable formats on all backends.
On 2016/08/15 16:24:08, bsalomon wrote:
> I don't know that the fundamental problem is renderability. ES 3.2 does
require
> they're renderable, but it still doesn't guarantee support that they can be
> read. The real problem is that you can't use them as a read back format.

Done.

[egdaniel, 2016-08-15 17:40:54]

The CQ bit was checked by egdaniel@google.com

[egdaniel, 2016-08-15 17:40:54]

The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com
Link to the patchset: https://codereview.chromium.org/2238563002/#ps100001
(title: "update comment")

[commit-bot: I haz the power, 2016-08-15 17:41:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-15 17:59:21]

Description was changed from

==========
Fix 4444 on Vulkan devices who don't support RGBA_4444

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2238563002

Committed:
https://skia.googlesource.com/skia/+/637b3bf2b9c10398d823bd015a722842d4f2f971
==========

to

==========
Fix 4444 on Vulkan devices who don't support RGBA_4444

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2238563002

Committed:
https://skia.googlesource.com/skia/+/637b3bf2b9c10398d823bd015a722842d4f2f971
Committed:
https://skia.googlesource.com/skia/+/3fe0327585f32ea2b9334965d8c90d9d699c584e
==========

[commit-bot: I haz the power, 2016-08-15 17:59:22]

Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/3fe0327585f32ea2b9334965d8c90d9d699c584e