Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6934)

Unified Diff: chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc

Issue 2238543002: Instrument parser blocking script execution time. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comment Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc
diff --git a/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc b/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc
index 153228f9b3f71447394cac069c0e656a8d414e14..a8805849f5021e5938c201c5acf601e8780f0b88 100644
--- a/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc
+++ b/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc
@@ -89,10 +89,18 @@ void PageLoadMetricsObserverTestHarness::PopulateRequiredTimingFields(
if (inout_timing->parse_start) {
if (!inout_timing->parse_blocked_on_script_load_duration)
inout_timing->parse_blocked_on_script_load_duration = base::TimeDelta();
+ if (!inout_timing->parse_blocked_on_script_execution_duration)
Charlie Harrison 2016/09/07 14:57:37 Optional nit: It makes me nervous to have multi-li
Bryan McQuade 2016/09/07 18:26:09 Sure, makes sense. I fixed a few other cases as we
Charlie Harrison 2016/09/07 18:32:50 Thanks!
+ inout_timing->parse_blocked_on_script_execution_duration =
+ base::TimeDelta();
if (!inout_timing
->parse_blocked_on_script_load_from_document_write_duration)
inout_timing->parse_blocked_on_script_load_from_document_write_duration =
base::TimeDelta();
+ if (!inout_timing
+ ->parse_blocked_on_script_execution_from_document_write_duration)
+ inout_timing
+ ->parse_blocked_on_script_execution_from_document_write_duration =
+ base::TimeDelta();
}
}

Powered by Google App Engine
This is Rietveld 408576698