Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10589)

Unified Diff: chrome/common/page_load_metrics/page_load_timing.cc

Issue 2238543002: Instrument parser blocking script execution time. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/page_load_metrics/page_load_timing.cc
diff --git a/chrome/common/page_load_metrics/page_load_timing.cc b/chrome/common/page_load_metrics/page_load_timing.cc
index d96844881c72490c9aa961af1ed3f5712b36fe83..3f0925893c40a0eba879b36cdb7bafa3130c783c 100644
--- a/chrome/common/page_load_metrics/page_load_timing.cc
+++ b/chrome/common/page_load_metrics/page_load_timing.cc
@@ -28,7 +28,12 @@ bool PageLoadTiming::operator==(const PageLoadTiming& other) const {
parse_blocked_on_script_load_duration ==
other.parse_blocked_on_script_load_duration &&
parse_blocked_on_script_load_from_document_write_duration ==
- other.parse_blocked_on_script_load_from_document_write_duration;
+ other.parse_blocked_on_script_load_from_document_write_duration &&
+ parse_blocked_on_script_execution_duration ==
+ other.parse_blocked_on_script_execution_duration &&
+ parse_blocked_on_script_execution_from_document_write_duration ==
+ other
+ .parse_blocked_on_script_execution_from_document_write_duration;
}
bool PageLoadTiming::IsEmpty() const {
@@ -38,7 +43,9 @@ bool PageLoadTiming::IsEmpty() const {
!first_image_paint && !first_contentful_paint &&
!first_meaningful_paint && !parse_start && !parse_stop &&
!parse_blocked_on_script_load_duration &&
- !parse_blocked_on_script_load_from_document_write_duration;
+ !parse_blocked_on_script_load_from_document_write_duration &&
+ !parse_blocked_on_script_execution_duration &&
+ !parse_blocked_on_script_execution_from_document_write_duration;
}
PageLoadMetadata::PageLoadMetadata() {}

Powered by Google App Engine
This is Rietveld 408576698