chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc - Issue 2238543002: Instrument parser blocking script execution time.

Side by Side Diff: chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc

Issue 2238543002: Instrument parser blocking script execution time. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comment Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc ('K') | « chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc ('k') | chrome/common/page_load_metrics/page_load_metrics_messages.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2015 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "base/macros.h"	5 #include "base/macros.h"

6 #include "base/test/histogram_tester.h"	6 #include "base/test/histogram_tester.h"

7 #include "chrome/browser/page_load_metrics/metrics_web_contents_observer.h"	7 #include "chrome/browser/page_load_metrics/metrics_web_contents_observer.h"

8 #include "chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_ob server.h"	8 #include "chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_ob server.h"

9 #include "chrome/browser/page_load_metrics/observers/core_page_load_metrics_obse rver.h"	9 #include "chrome/browser/page_load_metrics/observers/core_page_load_metrics_obse rver.h"

10 #include "chrome/browser/page_load_metrics/observers/document_write_page_load_me trics_observer.h"	10 #include "chrome/browser/page_load_metrics/observers/document_write_page_load_me trics_observer.h"

(...skipping 36 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
47 ui_test_utils::NavigateToURL(browser(),	47 ui_test_utils::NavigateToURL(browser(),

48 embedded_test_server()->GetURL("/title1.html"));	48 embedded_test_server()->GetURL("/title1.html"));

49 NavigateToUntrackedUrl();	49 NavigateToUntrackedUrl();

50	50

51 histogram_tester_.ExpectTotalCount(internal::kHistogramDomContentLoaded, 1);	51 histogram_tester_.ExpectTotalCount(internal::kHistogramDomContentLoaded, 1);

52 histogram_tester_.ExpectTotalCount(internal::kHistogramLoad, 1);	52 histogram_tester_.ExpectTotalCount(internal::kHistogramLoad, 1);

53 histogram_tester_.ExpectTotalCount(internal::kHistogramFirstLayout, 1);	53 histogram_tester_.ExpectTotalCount(internal::kHistogramFirstLayout, 1);

54 histogram_tester_.ExpectTotalCount(internal::kHistogramParseDuration, 1);	54 histogram_tester_.ExpectTotalCount(internal::kHistogramParseDuration, 1);

55 histogram_tester_.ExpectTotalCount(	55 histogram_tester_.ExpectTotalCount(

56 internal::kHistogramParseBlockedOnScriptLoad, 1);	56 internal::kHistogramParseBlockedOnScriptLoad, 1);

	57 histogram_tester_.ExpectTotalCount(

	58 internal::kHistogramParseBlockedOnScriptExecution, 1);

57 }	59 }

58	60

59 IN_PROC_BROWSER_TEST_F(MetricsWebContentsObserverBrowserTest,	61 IN_PROC_BROWSER_TEST_F(MetricsWebContentsObserverBrowserTest,

60 SamePageNavigation) {	62 SamePageNavigation) {

61 ASSERT_TRUE(embedded_test_server()->Start());	63 ASSERT_TRUE(embedded_test_server()->Start());

62	64

63 ui_test_utils::NavigateToURL(browser(),	65 ui_test_utils::NavigateToURL(browser(),

64 embedded_test_server()->GetURL("/title1.html"));	66 embedded_test_server()->GetURL("/title1.html"));

65 ui_test_utils::NavigateToURL(	67 ui_test_utils::NavigateToURL(

66 browser(), embedded_test_server()->GetURL("/title1.html#hash"));	68 browser(), embedded_test_server()->GetURL("/title1.html#hash"));

(...skipping 351 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
418 NavigateToUntrackedUrl();	420 NavigateToUntrackedUrl();

419	421

420 histogram_tester_.ExpectUniqueSample(	422 histogram_tester_.ExpectUniqueSample(

421 internal::kHistogramFirstMeaningfulPaintStatus,	423 internal::kHistogramFirstMeaningfulPaintStatus,

422 internal::FIRST_MEANINGFUL_PAINT_DID_NOT_REACH_NETWORK_STABLE, 1);	424 internal::FIRST_MEANINGFUL_PAINT_DID_NOT_REACH_NETWORK_STABLE, 1);

423 histogram_tester_.ExpectTotalCount(	425 histogram_tester_.ExpectTotalCount(

424 internal::kHistogramFirstMeaningfulPaint, 0);	426 internal::kHistogramFirstMeaningfulPaint, 0);

425 histogram_tester_.ExpectTotalCount(	427 histogram_tester_.ExpectTotalCount(

426 internal::kHistogramParseStartToFirstMeaningfulPaint, 0);	428 internal::kHistogramParseStartToFirstMeaningfulPaint, 0);

427 }	429 }

OLD	NEW