Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 2238523002: [LayoutNG] Initial version of NGBox wrapper object. (Closed)

Created:
4 years, 4 months ago by ikilpatrick
Modified:
4 years, 4 months ago
Reviewers:
cbiesinger, Gleb Lanbin, eae
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[LayoutNG] Initial version of NGBox wrapper object. This will allow us to cheaply wrap the old layout tree; and provide as an input to the layout algorithm. NOTRY=true BUG=635619 Committed: https://crrev.com/c653e981b3fe30f70afbc318785f3072b66373d5 Cr-Commit-Position: refs/heads/master@{#411093}

Patch Set 1 #

Total comments: 5

Patch Set 2 : back to const ComputedStyle. #

Total comments: 1

Patch Set 3 : s/mutableStyle/style #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -4 lines) Patch
M third_party/WebKit/Source/core/core.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h View 1 3 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc View 1 2 chunks +9 lines, -2 lines 0 comments Download
A third_party/WebKit/Source/core/layout/ng/ng_box.h View 1 1 chunk +39 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/layout/ng/ng_box.cc View 1 2 1 chunk +29 lines, -0 lines 0 comments Download

Messages

Total messages: 28 (18 generated)
ikilpatrick
4 years, 4 months ago (2016-08-10 15:23:08 UTC) #4
eae
OK. LGTM
4 years, 4 months ago (2016-08-10 15:25:01 UTC) #5
cbiesinger
lgtm
4 years, 4 months ago (2016-08-10 15:28:47 UTC) #8
Gleb Lanbin
lgtm https://codereview.chromium.org/2238523002/diff/1/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc File third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc (right): https://codereview.chromium.org/2238523002/diff/1/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc#newcode10 third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc:10: #include "core/style/ComputedStyle.h" ditto. https://codereview.chromium.org/2238523002/diff/1/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h File third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h (right): https://codereview.chromium.org/2238523002/diff/1/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h#newcode9 ...
4 years, 4 months ago (2016-08-10 15:35:32 UTC) #9
ikilpatrick
https://codereview.chromium.org/2238523002/diff/1/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h File third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h (right): https://codereview.chromium.org/2238523002/diff/1/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h#newcode9 third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h:9: #include "wtf/RefPtr.h" On 2016/08/10 15:35:32, glebl wrote: > we ...
4 years, 4 months ago (2016-08-10 16:20:29 UTC) #10
cbiesinger
lgtm https://codereview.chromium.org/2238523002/diff/20001/third_party/WebKit/Source/core/layout/ng/ng_box.cc File third_party/WebKit/Source/core/layout/ng/ng_box.cc (right): https://codereview.chromium.org/2238523002/diff/20001/third_party/WebKit/Source/core/layout/ng/ng_box.cc#newcode18 third_party/WebKit/Source/core/layout/ng/ng_box.cc:18: return m_layoutObject->mutableStyle(); This can now be style()
4 years, 4 months ago (2016-08-10 16:21:43 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2238523002/40001
4 years, 4 months ago (2016-08-10 17:05:36 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2238523002/40001
4 years, 4 months ago (2016-08-10 18:30:10 UTC) #24
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-10 18:36:33 UTC) #26
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 18:38:54 UTC) #28
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c653e981b3fe30f70afbc318785f3072b66373d5
Cr-Commit-Position: refs/heads/master@{#411093}

Powered by Google App Engine
This is Rietveld 408576698