Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 2238503002: Elide LifecycleObserver<T,O>::Context type alias. (Closed)

Created:
4 years, 4 months ago by sof
Modified:
4 years, 4 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Elide LifecycleObserver<T,O>::Context type alias. No longer a need to bind LifecycleObserver<T, O>'s T parameter to a separate alias/name; simplify to LifecycleObserver<Context, O>. R= BUG= Committed: https://crrev.com/1634ea1f39f2387d1fc64e273a77446fb8306985 Cr-Commit-Position: refs/heads/master@{#411271}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M third_party/WebKit/Source/platform/LifecycleObserver.h View 2 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
sof
please take a look.
4 years, 4 months ago (2016-08-10 13:53:28 UTC) #4
haraken
LGTM
4 years, 4 months ago (2016-08-10 14:22:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2238503002/1
4 years, 4 months ago (2016-08-11 05:14:08 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-11 05:17:12 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-11 05:19:06 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1634ea1f39f2387d1fc64e273a77446fb8306985
Cr-Commit-Position: refs/heads/master@{#411271}

Powered by Google App Engine
This is Rietveld 408576698