Revert "ios: fix path to the test app"

Revert "ios: fix path to the test app"

This reverts commit 15eadb86674b47f07b21648deb3302b4c9891357.

Revert "ios: fix iossim path"

This reverts commit 9aa6e0a8124b331eb3c68900172ecbeb293deba3.

Reason for revert:
Relative paths must be used for the command when Swarming. These changes broke the ios-simulator-swarming experimental try bot.

BUG=598405
TBR=phajdan,sergiyb

Committed: https://chromium.googlesource.com/chromium/tools/build/+/a7d2fc32f5b0db4a878246303e1794867ea580e3

[smut, 2016-08-10 23:56:13]

smut@google.com changed reviewers:
+ phajdan@google.com, sergiyb@chromium.org

[smut, 2016-08-10 23:56:24]

Description was changed from

==========
Revert "ios: fix path to the test app"

This reverts commit 15eadb86674b47f07b21648deb3302b4c9891357.

Revert "ios: fix iossim path"

This reverts commit 9aa6e0a8124b331eb3c68900172ecbeb293deba3.

Reason for revert:
Relative paths must be used for the command when Swarming. These changes broke
the ios-simulator-swarming experimental try bot.

BUG=598405
==========

to

==========
Revert "ios: fix path to the test app"

This reverts commit 15eadb86674b47f07b21648deb3302b4c9891357.

Revert "ios: fix iossim path"

This reverts commit 9aa6e0a8124b331eb3c68900172ecbeb293deba3.

Reason for revert:
Relative paths must be used for the command when Swarming. These changes broke
the ios-simulator-swarming experimental try bot.

BUG=598405
TBR=phajdan,sergiyb
==========

[smut, 2016-08-10 23:56:28]

The CQ bit was checked by smut@google.com

[commit-bot: I haz the power, 2016-08-10 23:56:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 00:00:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-11 00:00:45]

Try jobs failed on following builders:
  Recipe Roll Downstream Tester on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/308fb672be455e10)

[Paweł Hajdan Jr., 2016-08-11 09:18:30]

phajdan.jr@chromium.org changed reviewers:
+ phajdan.jr@chromium.org

[Paweł Hajdan Jr., 2016-08-11 09:18:31]

Whoa, watch out. If this landed, I believe it'd have broken ios CQ trybots.

Can you find a way not to use slave_build for this? It's an assumption which is
no longer true.

See e.g. how chromium_tests stores work dir in ctor and ensure_checkout and
later uses that e.g. as cwd.

If you have more questions, just let me know. Feel free to send me email, CLs,
or ping on IM.

[smut, 2016-08-11 21:33:06]

On 2016/08/11 09:18:31, Paweł Hajdan Jr. wrote:
> Whoa, watch out. If this landed, I believe it'd have broken ios CQ trybots.
> 
> Can you find a way not to use slave_build for this? It's an assumption which
is
> no longer true.
> 
> See e.g. how chromium_tests stores work dir in ctor and ensure_checkout and
> later uses that e.g. as cwd.
> 
> If you have more questions, just let me know. Feel free to send me email, CLs,
> or ping on IM.

Why would this break iOS CQ bots? Prior to your change, iOS try bots all worked
fine. After your change, iOS Swarming try bot was broken.

[smut, 2016-08-11 21:37:22]

On 2016/08/11 21:33:06, smut wrote:
> On 2016/08/11 09:18:31, Paweł Hajdan Jr. wrote:
> > Whoa, watch out. If this landed, I believe it'd have broken ios CQ trybots.
> > 
> > Can you find a way not to use slave_build for this? It's an assumption which
> is
> > no longer true.
> > 
> > See e.g. how chromium_tests stores work dir in ctor and ensure_checkout and
> > later uses that e.g. as cwd.
> > 
> > If you have more questions, just let me know. Feel free to send me email,
CLs,
> > or ping on IM.
> 
> Why would this break iOS CQ bots? Prior to your change, iOS try bots all
worked
> fine. After your change, iOS Swarming try bot was broken.

Plenty of recipes have SLAVE_BUILD still set. What do you mean it's an
assumption that isn't true?

[smut, 2016-08-11 21:37:28]

The CQ bit was checked by smut@google.com

[commit-bot: I haz the power, 2016-08-11 21:37:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 21:42:10]

Description was changed from

==========
Revert "ios: fix path to the test app"

This reverts commit 15eadb86674b47f07b21648deb3302b4c9891357.

Revert "ios: fix iossim path"

This reverts commit 9aa6e0a8124b331eb3c68900172ecbeb293deba3.

Reason for revert:
Relative paths must be used for the command when Swarming. These changes broke
the ios-simulator-swarming experimental try bot.

BUG=598405
TBR=phajdan,sergiyb
==========

to

==========
Revert "ios: fix path to the test app"

This reverts commit 15eadb86674b47f07b21648deb3302b4c9891357.

Revert "ios: fix iossim path"

This reverts commit 9aa6e0a8124b331eb3c68900172ecbeb293deba3.

Reason for revert:
Relative paths must be used for the command when Swarming. These changes broke
the ios-simulator-swarming experimental try bot.

BUG=598405
TBR=phajdan,sergiyb

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/a7d2fc32f5b0db4a8782...
==========

[commit-bot: I haz the power, 2016-08-11 21:42:13]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/build/+/a7d2fc32f5b0db4a8782...

[ehmaldonado_chromium, 2016-08-12 09:50:28]

On 2016/08/11 21:42:13, commit-bot: I haz the power wrote:
> Committed patchset #2 (id:20001) as
>
https://chromium.googlesource.com/chromium/tools/build/+/a7d2fc32f5b0db4a8782...

Hi, I think this might be breaking our bots.
https://build.chromium.org/p/client.webrtc/builders/iOS32%20Simulator%20Debug
https://build.chromium.org/p/client.webrtc/builders/iOS64%20Simulator%20Debug


They're failing now with the error
App does not exist:
/b/rr/tmpV7gcmZ/w/src/out/Debug-iphonesimulator/audio_decoder_unittests.app

https://build.chromium.org/p/client.webrtc/builders/iOS32%20Simulator%20Debug...

This is a build that works:
https://build.chromium.org/p/client.webrtc/builders/iOS32%20Simulator%20Debug...

Please take a look.

[ehmaldonado_chromium, 2016-08-12 12:31:07]

On 2016/08/12 09:50:28, ehmaldonado_chromium wrote:
> On 2016/08/11 21:42:13, commit-bot: I haz the power wrote:
> > Committed patchset #2 (id:20001) as
> >
>
https://chromium.googlesource.com/chromium/tools/build/+/a7d2fc32f5b0db4a8782...
> 
> Hi, I think this might be breaking our bots.
> https://build.chromium.org/p/client.webrtc/builders/iOS32%20Simulator%20Debug
> https://build.chromium.org/p/client.webrtc/builders/iOS64%20Simulator%20Debug
> 
> 
> They're failing now with the error
> App does not exist:
> /b/rr/tmpV7gcmZ/w/src/out/Debug-iphonesimulator/audio_decoder_unittests.app
> 
>
https://build.chromium.org/p/client.webrtc/builders/iOS32%20Simulator%20Debug...
> 
> This is a build that works:
>
https://build.chromium.org/p/client.webrtc/builders/iOS32%20Simulator%20Debug...
> 
> Please take a look.

ios32_sim_dbg and ios64_sim_dbg also
https://build.chromium.org/p/tryserver.webrtc/builders/ios32_sim_dbg
https://build.chromium.org/p/tryserver.webrtc/builders/ios64_sim_dbg

[ehmaldonado_chromium, 2016-08-12 12:31:51]

ehmaldonado@chromium.org changed reviewers:
+ ehmaldonado@chromium.org, kjellander@chromium.org

[ehmaldonado_chromium, 2016-08-12 12:31:52]

+kjellander

[smut, 2016-08-12 21:20:23]

On 2016/08/12 12:31:52, ehmaldonado_chromium wrote:
> +kjellander

Sorry for the inconvenience. The webrtc iOS try bots should also not use
remote_run.