Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Issue 2238443003: Fix for updating documentationComment for top-level variables. (Closed)

Created:
4 years, 4 months ago by scheglov
Modified:
4 years, 4 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix for updating documentationComment for top-level variables. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/fa11df13cabcba93e6c0dabafbb3b2c62c67b6bc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -7 lines) Patch
M pkg/analyzer/lib/src/generated/incremental_resolver.dart View 1 chunk +12 lines, -7 lines 0 comments Download
M pkg/analyzer/test/generated/incremental_resolver_test.dart View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 4 months ago (2016-08-10 17:25:36 UTC) #1
Brian Wilkerson
lgtm
4 years, 4 months ago (2016-08-10 17:26:46 UTC) #2
scheglov
4 years, 4 months ago (2016-08-10 17:29:19 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
fa11df13cabcba93e6c0dabafbb3b2c62c67b6bc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698