chrome/browser/task_manager/sampling/shared_sampler_posix.cc - Issue 2238403003: Task manager: Get physical memory efficiently for all processes from SharedSampler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/task_manager/sampling/shared_sampler_posix.cc

Issue 2238403003: Task manager: Get physical memory efficiently for all processes from SharedSampler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed CR feedback Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/task_manager/sampling/shared_sampler.h ('k') | chrome/browser/task_manager/sampling/shared_sampler_unittest_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/task_manager/sampling/shared_sampler_posix.cc

diff --git a/chrome/browser/task_manager/sampling/shared_sampler_posix.cc b/chrome/browser/task_manager/sampling/shared_sampler_posix.cc

index 57d89884d7610abdaaff3bbc59e2bc9a4be40842..722bf96a9156b1a370638256f53d178dbc519843 100644

--- a/chrome/browser/task_manager/sampling/shared_sampler_posix.cc

+++ b/chrome/browser/task_manager/sampling/shared_sampler_posix.cc

@@ -17,7 +17,8 @@ int64_t SharedSampler::GetSupportedFlags() const { return 0; }

void SharedSampler::RegisterCallbacks(

base::ProcessId process_id,

- const OnIdleWakeupsCallback& on_idle_wakeups) {}

+ const OnIdleWakeupsCallback& on_idle_wakeups,

+ const OnPhysicalMemoryCallback& on_physical_memory) {}

void SharedSampler::UnregisterCallbacks(base::ProcessId process_id) {}