Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 22384003: expose eternal handle api (Closed)

Created:
7 years, 4 months ago by dcarney
Modified:
7 years, 4 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : better location for helper functions #

Patch Set 3 : added uninitialized constant #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -9 lines) Patch
M include/v8.h View 1 2 4 chunks +28 lines, -0 lines 0 comments Download
M src/api.cc View 1 1 chunk +10 lines, -0 lines 0 comments Download
M src/global-handles.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-global-handles.cc View 1 1 chunk +24 lines, -9 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
dcarney
7 years, 4 months ago (2013-08-06 08:43:21 UTC) #1
Sven Panne
lgtm
7 years, 4 months ago (2013-08-07 07:36:10 UTC) #2
dcarney
7 years, 4 months ago (2013-08-07 08:26:31 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r16089 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698