chrome/test/data/extensions/api_test/webrequest/framework.js - Issue 2238383003: webRequest: Also identify frames for non-RDH-initiated requests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/api_test/webrequest/framework.js

Issue 2238383003: webRequest: Also identify frames for non-RDH-initiated requests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/web_request/web_request_apitest.cc ('K') | « chrome/browser/extensions/api/web_request/web_request_apitest.cc ('k') | chrome/test/data/extensions/api_test/webrequest/osdd/index.html » ('j') | chrome/test/data/extensions/api_test/webrequest/test_osdd.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/api_test/webrequest/framework.js

diff --git a/chrome/test/data/extensions/api_test/webrequest/framework.js b/chrome/test/data/extensions/api_test/webrequest/framework.js

index 5235846cf5d619f131b0350aa8eb09d102910dcb..079921f3e1671e1fd1b1f550a5a1ba44e96de8a7 100644

--- a/chrome/test/data/extensions/api_test/webrequest/framework.js

+++ b/chrome/test/data/extensions/api_test/webrequest/framework.js

@@ -204,7 +204,7 @@ function isUnexpectedDetachedRequest(name, details) {

function captureEvent(name, details, callback) {

// Ignore system-level requests like safebrowsing updates and favicon fetches

// since they are unpredictable.

- if (details.type == "other" ||

+ if (details.type == "other" && !details.url.includes('dont-ignore-me') ||

Marijn Kruisselbrink 2016/08/15 22:02:15 nit: I think this would be clearer with an extra p

robwu 2016/08/17 08:44:32 Done.

isUnexpectedDetachedRequest(name, details) ||

details.url.match(/\/favicon.ico$/) ||

details.url.match(/https:\/\/dl.google.com/))