Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(537)

Side by Side Diff: extensions/browser/api/web_request/web_request_event_details.cc

Issue 2238383003: webRequest: Also identify frames for non-RDH-initiated requests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix mek's nits Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/test/data/extensions/api_test/webrequest/test_osdd.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "extensions/browser/api/web_request/web_request_event_details.h" 5 #include "extensions/browser/api/web_request/web_request_event_details.h"
6 6
7 #include "base/callback.h" 7 #include "base/callback.h"
8 #include "base/strings/string_number_conversions.h" 8 #include "base/strings/string_number_conversions.h"
9 #include "content/public/browser/browser_thread.h" 9 #include "content/public/browser/browser_thread.h"
10 #include "content/public/browser/render_frame_host.h" 10 #include "content/public/browser/render_frame_host.h"
(...skipping 21 matching lines...) Expand all
32 : extra_info_spec_(extra_info_spec), 32 : extra_info_spec_(extra_info_spec),
33 render_process_id_(content::ChildProcessHost::kInvalidUniqueID), 33 render_process_id_(content::ChildProcessHost::kInvalidUniqueID),
34 render_frame_id_(MSG_ROUTING_NONE) { 34 render_frame_id_(MSG_ROUTING_NONE) {
35 content::ResourceType resource_type = content::RESOURCE_TYPE_LAST_TYPE; 35 content::ResourceType resource_type = content::RESOURCE_TYPE_LAST_TYPE;
36 const content::ResourceRequestInfo* info = 36 const content::ResourceRequestInfo* info =
37 content::ResourceRequestInfo::ForRequest(request); 37 content::ResourceRequestInfo::ForRequest(request);
38 if (info) { 38 if (info) {
39 render_process_id_ = info->GetChildID(); 39 render_process_id_ = info->GetChildID();
40 render_frame_id_ = info->GetRenderFrameID(); 40 render_frame_id_ = info->GetRenderFrameID();
41 resource_type = info->GetResourceType(); 41 resource_type = info->GetResourceType();
42 } else {
43 // Fallback for requests that are not allocated by a ResourceDispatcherHost,
44 // such as the TemplateURLFetcher.
45 content::ResourceRequestInfo::GetRenderFrameForRequest(
46 request, &render_process_id_, &render_frame_id_);
42 } 47 }
43 48
44 dict_.SetString(keys::kMethodKey, request->method()); 49 dict_.SetString(keys::kMethodKey, request->method());
45 dict_.SetString(keys::kRequestIdKey, 50 dict_.SetString(keys::kRequestIdKey,
46 base::Uint64ToString(request->identifier())); 51 base::Uint64ToString(request->identifier()));
47 dict_.SetDouble(keys::kTimeStampKey, base::Time::Now().ToDoubleT() * 1000); 52 dict_.SetDouble(keys::kTimeStampKey, base::Time::Now().ToDoubleT() * 1000);
48 dict_.SetString(keys::kTypeKey, helpers::ResourceTypeToString(resource_type)); 53 dict_.SetString(keys::kTypeKey, helpers::ResourceTypeToString(resource_type));
49 dict_.SetString(keys::kUrlKey, request->url().spec()); 54 dict_.SetString(keys::kUrlKey, request->url().spec());
50 } 55 }
51 56
(...skipping 141 matching lines...) Expand 10 before | Expand all | Expand 10 after
193 std::unique_ptr<WebRequestEventDetails> self, 198 std::unique_ptr<WebRequestEventDetails> self,
194 const DeterminedFrameDataCallback& callback, 199 const DeterminedFrameDataCallback& callback,
195 const ExtensionApiFrameIdMap::FrameData& frame_data) { 200 const ExtensionApiFrameIdMap::FrameData& frame_data) {
196 dict_.SetInteger(keys::kTabIdKey, frame_data.tab_id); 201 dict_.SetInteger(keys::kTabIdKey, frame_data.tab_id);
197 dict_.SetInteger(keys::kFrameIdKey, frame_data.frame_id); 202 dict_.SetInteger(keys::kFrameIdKey, frame_data.frame_id);
198 dict_.SetInteger(keys::kParentFrameIdKey, frame_data.parent_frame_id); 203 dict_.SetInteger(keys::kParentFrameIdKey, frame_data.parent_frame_id);
199 callback.Run(std::move(self)); 204 callback.Run(std::move(self));
200 } 205 }
201 206
202 } // namespace extensions 207 } // namespace extensions
OLDNEW
« no previous file with comments | « chrome/test/data/extensions/api_test/webrequest/test_osdd.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698