Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(709)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2238373002: Initial docs on the internals of the C bindings (Closed)

Created:
4 years, 4 months ago by vardhan
Modified:
4 years, 4 months ago
Reviewers:
jamesr, viettrungluu
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : formatting #

Patch Set 3 : oops, remove TODO in tutorial.md #

Total comments: 1

Patch Set 4 : link to INTERNALS.md in TUTORIAL.md #

Unified diffs Side-by-side diffs Delta from patch set Stats (+153 lines, -3 lines) Patch
A mojo/public/c/docs/bindings/INTERNALS.md View 1 1 chunk +151 lines, -0 lines 0 comments Download
M mojo/public/c/docs/bindings/TUTORIAL.md View 1 2 3 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
vardhan
PTAL
4 years, 4 months ago (2016-08-12 22:18:01 UTC) #1
vardhan
CCing jamesr, since trung is OOO. prereq doc: https://github.com/domokit/mojo/blob/master/mojo/public/c/docs/bindings/TUTORIAL.md
4 years, 4 months ago (2016-08-15 21:50:32 UTC) #3
jamesr
lgtm https://codereview.chromium.org/2238373002/diff/40001/mojo/public/c/docs/bindings/TUTORIAL.md File mojo/public/c/docs/bindings/TUTORIAL.md (left): https://codereview.chromium.org/2238373002/diff/40001/mojo/public/c/docs/bindings/TUTORIAL.md#oldcode373 mojo/public/c/docs/bindings/TUTORIAL.md:373: TODO(vardhan): Probably as a separate doc? leave a ...
4 years, 4 months ago (2016-08-15 22:38:27 UTC) #4
vardhan
4 years, 4 months ago (2016-08-16 00:01:13 UTC) #6
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
33283a53eaac442eed88ddd35e739ef79fcbd6ff (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698