Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2238333002:
gpu: Fix gtest recipes to be compatible with unified swarming logcat. (Closed)
Descriptiongpu: Fix gtest recipes to be compatible with unified swarming logcat.
TBR=kbr@chromium.org,nicholaslin@google.com
BUG=637382
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Committed: https://crrev.com/5296a496b951bb0d67a7e1d89106d442bd2174e0
Cr-Commit-Position: refs/heads/master@{#411787}
Patch Set 1 #
Total comments: 2
Patch Set 2 : only android #
Messages
Total messages: 25 (17 generated)
Description was changed from ========== gpu: Fix gtest recipes to be compatible with unified swarming logcat. TBR=kbr@chromium.org,nicholaslin@google.com BUG=637382 ========== to ========== gpu: Fix gtest recipes to be compatible with unified swarming logcat. TBR=kbr@chromium.org,nicholaslin@google.com BUG=637382 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
PTAL
The CQ bit was checked by sunnyps@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
ynovikov@google.com changed reviewers: + ynovikov@google.com
https://codereview.chromium.org/2238333002/diff/1/content/test/gpu/generate_b... File content/test/gpu/generate_buildbot_json.py (right): https://codereview.chromium.org/2238333002/diff/1/content/test/gpu/generate_b... content/test/gpu/generate_buildbot_json.py:1091: 'cipd_packages': [ As I understood, we need this only for Android targets? Perhaps wrap this with "is_android(tester_config)"?
The CQ bit was checked by sunnyps@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
PTAL https://codereview.chromium.org/2238333002/diff/1/content/test/gpu/generate_b... File content/test/gpu/generate_buildbot_json.py (right): https://codereview.chromium.org/2238333002/diff/1/content/test/gpu/generate_b... content/test/gpu/generate_buildbot_json.py:1091: 'cipd_packages': [ On 2016/08/12 19:45:18, ynovikov1 wrote: > As I understood, we need this only for Android targets? > Perhaps wrap this with "is_android(tester_config)"? Yes, I realized this shortly after uploading. New patch restricts it to android
On 2016/08/12 19:49:19, sunnyps wrote: > PTAL > > https://codereview.chromium.org/2238333002/diff/1/content/test/gpu/generate_b... > File content/test/gpu/generate_buildbot_json.py (right): > > https://codereview.chromium.org/2238333002/diff/1/content/test/gpu/generate_b... > content/test/gpu/generate_buildbot_json.py:1091: 'cipd_packages': [ > On 2016/08/12 19:45:18, ynovikov1 wrote: > > As I understood, we need this only for Android targets? > > Perhaps wrap this with "is_android(tester_config)"? > > Yes, I realized this shortly after uploading. New patch restricts it to android lgtm Please try this on android_optional_gpu_tests_rel before landing. I can't figure out how to add the trybot to the list.
LGTM, but this looks like a fairly nasty regression that happened because of some other configuration change and it seems impractical to keep the hash, cipd_package, etc. in sync with whatever pushes them in the first place. I think we should discuss this dependency with the infra team at some point.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== gpu: Fix gtest recipes to be compatible with unified swarming logcat. TBR=kbr@chromium.org,nicholaslin@google.com BUG=637382 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== gpu: Fix gtest recipes to be compatible with unified swarming logcat. TBR=kbr@chromium.org,nicholaslin@google.com BUG=637382 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.android:android_optional_gpu_tests_rel ==========
Description was changed from ========== gpu: Fix gtest recipes to be compatible with unified swarming logcat. TBR=kbr@chromium.org,nicholaslin@google.com BUG=637382 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.android:android_optional_gpu_tests_rel ========== to ========== gpu: Fix gtest recipes to be compatible with unified swarming logcat. TBR=kbr@chromium.org,nicholaslin@google.com BUG=637382 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ==========
The CQ bit was checked by sunnyps@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by sunnyps@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== gpu: Fix gtest recipes to be compatible with unified swarming logcat. TBR=kbr@chromium.org,nicholaslin@google.com BUG=637382 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ========== to ========== gpu: Fix gtest recipes to be compatible with unified swarming logcat. TBR=kbr@chromium.org,nicholaslin@google.com BUG=637382 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== gpu: Fix gtest recipes to be compatible with unified swarming logcat. TBR=kbr@chromium.org,nicholaslin@google.com BUG=637382 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ========== to ========== gpu: Fix gtest recipes to be compatible with unified swarming logcat. TBR=kbr@chromium.org,nicholaslin@google.com BUG=637382 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Committed: https://crrev.com/5296a496b951bb0d67a7e1d89106d442bd2174e0 Cr-Commit-Position: refs/heads/master@{#411787} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/5296a496b951bb0d67a7e1d89106d442bd2174e0 Cr-Commit-Position: refs/heads/master@{#411787} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
