Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2238313002:
Adjust visual rect checks to account for slop in old visual rect computations. (Closed)
|
Created:
4 years, 4 months ago by chrishtr Modified:
4 years, 4 months ago Reviewers:
Xianzhu CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, slimming-paint-reviews_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdjust visual rect checks to account for slop in old visual rect computations.
BUG=611379
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Committed: https://crrev.com/638d3879d7acf7e999f82846fec024e433c7cd74
Cr-Commit-Position: refs/heads/master@{#411708}
Patch Set 1 #
Total comments: 2
Patch Set 2 : none #Messages
Total messages: 18 (11 generated)
Description was changed from ========== none BUG= ========== to ========== none BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ==========
Description was changed from ========== none BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ========== to ========== Adjust visual rect checks to account for slop in old visual rect computations. BUG=611379 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ==========
chrishtr@chromium.org changed reviewers: + wangxianzhu@chromium.org
The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2238313002/diff/1/third_party/WebKit/Source/c... File third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp (right): https://codereview.chromium.org/2238313002/diff/1/third_party/WebKit/Source/c... third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp:70: EXPECT_TRUE(LayoutRect(actual).contains(expected)); \ This seems to result false-negative if actual is much bigger than expected.
https://codereview.chromium.org/2238313002/diff/1/third_party/WebKit/Source/c... File third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp (right): https://codereview.chromium.org/2238313002/diff/1/third_party/WebKit/Source/c... third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp:70: EXPECT_TRUE(LayoutRect(actual).contains(expected)); \ On 2016/08/12 at 16:40:53, Xianzhu wrote: > This seems to result false-negative if actual is much bigger than expected. Oops. Good catch, fixed.
The CQ bit was checked by wangxianzhu@chromium.org
lgtm
The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by chrishtr@chromium.org
The CQ bit was checked by chrishtr@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Adjust visual rect checks to account for slop in old visual rect computations. BUG=611379 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ========== to ========== Adjust visual rect checks to account for slop in old visual rect computations. BUG=611379 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/638d3879d7acf7e999f82846fec024e433c7cd74 Cr-Commit-Position: refs/heads/master@{#411708} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/638d3879d7acf7e999f82846fec024e433c7cd74 Cr-Commit-Position: refs/heads/master@{#411708} |
