Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 2238283002: Revert of [interpreter] Inline ForInFilter stub. (Closed)

Created:
4 years, 4 months ago by rmcilroy
Modified:
4 years, 4 months ago
Reviewers:
oth
CC:
v8-reviews_googlegroups.com, oth, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [interpreter] Inline ForInFilter stub. (patchset #1 id:1 of https://codereview.chromium.org/2220343002/ ) Reason for revert: Speculative revert to possible performance regressions. BUG=chromium:635826, chromium:635930 Original issue's description: > [interpreter] Inline ForInFilter stub. > > BUG=v8:4280 > LOG=N > > Committed: https://crrev.com/2bf0b8c8ed5d0c93982c8c227e93622aceecea16 > Cr-Commit-Position: refs/heads/master@{#38420} TBR=oth@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=v8:4280 Committed: https://crrev.com/bbd0a093ca770daa286ea9469c5c851bb8230b9c Cr-Commit-Position: refs/heads/master@{#38623}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M src/interpreter/interpreter.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
rmcilroy
Created Revert of [interpreter] Inline ForInFilter stub.
4 years, 4 months ago (2016-08-12 13:34:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2238283002/1
4 years, 4 months ago (2016-08-12 13:34:16 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-12 14:00:12 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 14:00:37 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bbd0a093ca770daa286ea9469c5c851bb8230b9c
Cr-Commit-Position: refs/heads/master@{#38623}

Powered by Google App Engine
This is Rietveld 408576698