Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 2238243002: IWYU: ffloor(3) needs <cmath>. (Closed)

Created:
4 years, 4 months ago by Raphael Kubo da Costa (rakuco)
Modified:
4 years, 4 months ago
Reviewers:
danakj, hubbe, ccameron
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

IWYU: ffloor(3) needs <cmath>. This fixes the build with recent libstdc++ versions (mine is at 6.1.1), which do not implicitly include <cmath> and cause the build to fail like this after commit af57af3079ddbb21be992e839023ff6e45ec6ef4 ("Video Color Managament"): ../cc/output/color_lut_cache.cc:36:46: error: use of undeclared identifier 'floorf' R=hubbe@chromium.org,ccameron@chromium.org,danakj@chromium.org BUG=622133 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/06a769dce6003de32a7b510c2d13874a440ac28e Cr-Commit-Position: refs/heads/master@{#411798}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M cc/output/color_lut_cache.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Raphael Kubo da Costa (rakuco)
4 years, 4 months ago (2016-08-12 10:57:55 UTC) #2
hubbe
lgtm
4 years, 4 months ago (2016-08-12 16:37:51 UTC) #3
danakj
LGTM
4 years, 4 months ago (2016-08-12 18:00:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2238243002/1
4 years, 4 months ago (2016-08-12 20:53:16 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-12 22:25:06 UTC) #7
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 22:28:06 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/06a769dce6003de32a7b510c2d13874a440ac28e
Cr-Commit-Position: refs/heads/master@{#411798}

Powered by Google App Engine
This is Rietveld 408576698