Use experimentation framework parameters for location sensitivity

chrome/browser/resources/google_now/background.js

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 'use strict';
 
 /**
  * @fileoverview The event page for Google Now for Chrome implementation.
  * The Google Now event page gets Google Now cards from the server and shows
  * them as Chrome notifications.
@@ skipping 103 matching lines @@
   return false;
 }
 
 var googleGeolocationAccessEnabledPref =
     chrome.preferencesPrivate.googleGeolocationAccessEnabled;
 
 var tasks = buildTaskManager(areTasksConflicting);
 
 // Add error processing to API calls.
 tasks.instrumentApiFunction(chrome.location.onLocationUpdate, 'addListener', 0);
+tasks.instrumentApiFunction(chrome.metricsPrivate, 'getVariationParams', 1);

[robliao, 2013/08/09 22:01:54]

Sync to the latest for updating to instrumentChromeApiFunction.

[vadimt, 2013/08/09 22:08:59]

Will do before submittinng to CQ.

 tasks.instrumentApiFunction(chrome.notifications, 'create', 2);
 tasks.instrumentApiFunction(chrome.notifications, 'update', 2);
 tasks.instrumentApiFunction(chrome.notifications, 'getAll', 0);
 tasks.instrumentApiFunction(
     chrome.notifications.onButtonClicked, 'addListener', 0);
 tasks.instrumentApiFunction(chrome.notifications.onClicked, 'addListener', 0);
 tasks.instrumentApiFunction(chrome.notifications.onClosed, 'addListener', 0);
 tasks.instrumentApiFunction(chrome.omnibox.onInputEntered, 'addListener', 0);
 tasks.instrumentApiFunction(
     googleGeolocationAccessEnabledPref,
@@ skipping 260 matching lines @@
     }
   });
 }
 
 /**
  * Starts getting location for a cards update.
  */
 function requestLocation() {
   console.log('requestLocation');
   recordEvent(GoogleNowEvent.LOCATION_REQUEST);
-  // TODO(vadimt): Figure out location request options. Use experiments
-  // framework to enable setting these parameters remotely.
-  chrome.location.watchLocation(LOCATION_WATCH_NAME, {
-    minDistanceInMeters: 100,
-    minTimeInMilliseconds: 180000  // 3 minutes.
+  // TODO(vadimt): Figure out location request options.
+  chrome.metricsPrivate.getVariationParams('GoogleNow', function(params) {
+    var minDistanceInMeters =
+        parseInt(params && params.minDistanceInMeters) ||

[arv (Not doing code reviews), 2013/08/09 23:13:16]

don't use parseInt without radix

[vadimt, 2013/08/10 01:16:07]

Done.

+        100;
+    var minTimeInMilliseconds =
+        parseInt(params && params.minTimeInMilliseconds) ||
+        180000;  // 3 minutes.
+
+    chrome.location.watchLocation(LOCATION_WATCH_NAME, {
+      minDistanceInMeters: minDistanceInMeters,
+      minTimeInMilliseconds: minTimeInMilliseconds
+    });
   });
 }
 
 /**
  * Stops getting the location.
  */
 function stopRequestLocation() {
   console.log('stopRequestLocation');
   chrome.location.clearWatch(LOCATION_WATCH_NAME);
 }
@@ skipping 489 matching lines @@
 
 chrome.location.onLocationUpdate.addListener(function(position) {
   recordEvent(GoogleNowEvent.LOCATION_UPDATE);
   updateNotificationsCards(position);
 });
 
 chrome.omnibox.onInputEntered.addListener(function(text) {
   localStorage['server_url'] = NOTIFICATION_CARDS_URL = text;
   initialize();
 });