Issue 22382002: Rename VolumeList -> NavigationList in Files.app

Issue 22382002: Rename VolumeList -> NavigationList in Files.app (Closed)

Created:
7 years, 4 months ago by yoshiki

Modified:
7 years, 4 months ago

Reviewers:
mtomasz

CC:
chromium-reviews, rginda+watch_chromium.org, arv+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Rename VolumeList -> NavigationList in Files.app BUG=268812 TEST=Files.app runs without error. All tests pass. R=mtomasz@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215855

Patch Set 3 : addressed comment #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+108 lines, -536 lines)			Patch
M	chrome/browser/resources/file_manager/js/background.js	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/file_manager/js/file_manager.js	View	1 2	6 chunks	+15 lines, -15 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/file_manager_commands.js	View	1 2	10 chunks	+37 lines, -35 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/file_transfer_controller.js	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/folder_shortcuts_data_model.js	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/resources/file_manager/js/main_scripts.js	View	1	1 chunk	+1 line, -1 line	0 comments	Download
A +	chrome/browser/resources/file_manager/js/navigation_list.js	View	1 2	19 chunks	+47 lines, -46 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/test_util.js	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
D	chrome/browser/resources/file_manager/js/volume_list.js	View		1 chunk	+0 lines, -432 lines	0 comments	Download
M	chrome/browser/resources/file_manager/main.html	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

mtomasz

lgtm, but please fix these comments/jsdocs: chrome/browser/resources/file_manager/js/background.js: // volume will appear on the volume list. ...

7 years, 4 months ago (2013-08-06 08:24:32 UTC) #2

yoshiki

Thanks. Going to commit. https://codereview.chromium.org/22382002/diff/3001/chrome/browser/resources/file_manager/js/navigation_list.js File chrome/browser/resources/file_manager/js/navigation_list.js (right): https://codereview.chromium.org/22382002/diff/3001/chrome/browser/resources/file_manager/js/navigation_list.js#newcode286 chrome/browser/resources/file_manager/js/navigation_list.js:286: this.pinnedItemList_); On 2013/08/06 08:24:32, mtomasz ...

7 years, 4 months ago (2013-08-06 08:33:59 UTC) #3

yoshiki

Committed patchset #3 manually as r215855 (presubmit successful).

7 years, 4 months ago (2013-08-06 08:35:19 UTC) #4

mtomasz

7 years, 4 months ago (2013-08-06 08:35:19 UTC) #5

Message was sent while issue was closed.

On 2013/08/06 08:33:59, yoshiki wrote:
> Thanks. Going to commit.
> 
>
https://codereview.chromium.org/22382002/diff/3001/chrome/browser/resources/f...
> File chrome/browser/resources/file_manager/js/navigation_list.js (right):
> 
>
https://codereview.chromium.org/22382002/diff/3001/chrome/browser/resources/f...
> chrome/browser/resources/file_manager/js/navigation_list.js:286:
> this.pinnedItemList_);
> On 2013/08/06 08:24:32, mtomasz wrote:
> > nit: Indentation is off.
> 
> Done.
> 
>
https://codereview.chromium.org/22382002/diff/3001/chrome/browser/resources/f...
> chrome/browser/resources/file_manager/js/navigation_list.js:400: // it is
> changed outside of the mavigate list.
> On 2013/08/06 08:24:32, mtomasz wrote:
> > nit: mavigate -> navigate
> 
> Done.

lgtm, thanks.

Expand Messages | Collapse Messages