Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(556)

Issue 2238193002: [test] Skip flaky sampler and cpu-profiler tests on windows. (Closed)

Created:
4 years, 4 months ago by Michael Achenbach
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] Skip flaky sampler and cpu-profiler tests on windows. BUG=v8:5193 NOTRY=true Committed: https://crrev.com/f93f39f0eb292803c065d637df35d58914ff4fc1 Cr-Commit-Position: refs/heads/master@{#38600}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M test/cctest/cctest.status View 5 chunks +18 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Michael Achenbach
PTAL
4 years, 4 months ago (2016-08-12 08:05:55 UTC) #3
Michael Starzinger
LGTM.
4 years, 4 months ago (2016-08-12 08:19:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2238193002/1
4 years, 4 months ago (2016-08-12 08:32:17 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-12 08:34:05 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 08:34:19 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f93f39f0eb292803c065d637df35d58914ff4fc1
Cr-Commit-Position: refs/heads/master@{#38600}

Powered by Google App Engine
This is Rietveld 408576698