Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Issue 2238173003: Android: Fix Thumbnail CreateSmallHolderBitmap() (Closed)

Created:
4 years, 4 months ago by no sievers
Modified:
4 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Android: Fix Thumbnail CreateSmallHolderBitmap() Need to alloc bitmap before creating canvas or it will create an empty bitmap instead of one in WHITE. BUG=636630 Committed: https://crrev.com/df099f06101f2b01d5aa39d96661ab77ad4d6621 Cr-Commit-Position: refs/heads/master@{#414778}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/android/thumbnail/thumbnail.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
no sievers
dtrainor, ptal!
4 years, 4 months ago (2016-08-13 00:57:38 UTC) #3
David Trainor- moved to gerrit
Wow... thanks! I missed this in the code review :(. lgtm
4 years, 4 months ago (2016-08-16 02:42:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2238173003/1
4 years, 3 months ago (2016-08-26 18:40:59 UTC) #6
commit-bot: I haz the power
Failed to apply the patch. On branch working_branch Your branch is up-to-date with 'origin/refs/pending/heads/master'. nothing ...
4 years, 3 months ago (2016-08-26 19:34:28 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 19:35:17 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/df099f06101f2b01d5aa39d96661ab77ad4d6621
Cr-Commit-Position: refs/heads/master@{#414778}

Powered by Google App Engine
This is Rietveld 408576698