Trigger Blink GC on v8::kGCCallbackFlagCollectAllExternalMemory

third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp

Index: third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp b/third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp
index 65d5796c042b88751e32c60eb7d3dc3f3e554f97..3a62d10f882d6bfdce69ec6c4a7f0e69c8895921 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp
@@ -376,7 +376,8 @@ void V8GCController::gcEpilogue(v8::Isolate* isolate, v8::GCType type, v8::GCCal
 
         // v8::kGCCallbackFlagCollectAllAvailableGarbage is used when V8 handles
         // low memory notifications.
-        if (flags & v8::kGCCallbackFlagCollectAllAvailableGarbage) {
+        if (flags & v8::kGCCallbackFlagCollectAllAvailableGarbage
+            && flags & v8::kGCCallbackFlagCollectAllExternalMemory) {

[haraken, 2016/08/25 05:22:29]

Add () to make the condition clearer.

Shouldn't it be ||, not &&?

[keishi, 2016/08/25 05:25:05]

oops. Done

             // This single GC is not enough. See the above comment.
             ThreadHeap::collectGarbage(BlinkGC::HeapPointersOnStack, BlinkGC::GCWithSweep, BlinkGC::ForcedGC);