Trigger Blink GC on v8::kGCCallbackFlagCollectAllExternalMemory

third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp

Index: third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp b/third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp
index c1f74c4286e808879c9edb1af455d55690c9cafd..bf64232e622ed582832347729c53ba0903b603f9 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp
@@ -387,6 +387,9 @@ void V8GCController::gcEpilogue(v8::Isolate* isolate, v8::GCType type, v8::GCCal
             if (ThreadState::current())
                 ThreadState::current()->schedulePreciseGC();
         }
+
+        if (flags & v8::kGCCallbackFlagCollectAllExternalMemory)

[haraken, 2016/08/12 07:08:48]

Do you think it's worth distinguishing kGCCallbackFlagCollectAllExternalMemory
from kGCCallbackFlagCollectAllAvailableGarbage?

[keishi, 2016/08/15 10:30:44]

I'm not sure. I was thinking of maybe calling MemoryCache::purgeAll
kGCCallbackFlagCollectAllExternalMemory in the future and
v8::Heap::CollectAllAvailableGarbage seems to be called from many places.

+            ThreadHeap::collectGarbage(BlinkGC::HeapPointersOnStack, BlinkGC::GCWithSweep, BlinkGC::ForcedGC);
     }
 
     TRACE_EVENT_INSTANT1(TRACE_DISABLED_BY_DEFAULT("devtools.timeline"), "UpdateCounters", TRACE_EVENT_SCOPE_THREAD, "data", InspectorUpdateCountersEvent::data());