Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Unified Diff: chrome/browser/resources/md_history/side_bar.js

Issue 2238163002: [MD History] Add UMA stats for switching views and the CBD button. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@start_focus_in_search_bar
Patch Set: add test, add grouped history Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/md_history/side_bar.js
diff --git a/chrome/browser/resources/md_history/side_bar.js b/chrome/browser/resources/md_history/side_bar.js
index 24443025905b2133633eae6984041ba7f590c04a..c62dc53a36ea14cf2a59020c3d07bfa6a450ba96 100644
--- a/chrome/browser/resources/md_history/side_bar.js
+++ b/chrome/browser/resources/md_history/side_bar.js
@@ -6,24 +6,22 @@ Polymer({
is: 'history-side-bar',
properties: {
- selectedPage: {
- type: String,
- notify: true
- },
+ selectedPage:
+ {type: String, notify: true},
tsergeant 2016/08/15 07:05:17 No need for a newline here
calamity 2016/08/17 03:15:29 Done.
route: Object,
showFooter: Boolean,
// If true, the sidebar is contained within an app-drawer.
- drawer: {
- type: Boolean,
- reflectToAttribute: true
- },
+ drawer: {type: Boolean, reflectToAttribute: true},
},
- /** @private */
- onSelectorActivate_: function() {
+ /**
+ * @param {Event} e
+ * @private
+ */
+ onSelectorActivate_: function(e) {
tsergeant 2016/08/15 07:05:18 No need to add the e parameter here.
calamity 2016/08/17 03:15:29 Done.
this.fire('history-close-drawer');
},
@@ -33,6 +31,8 @@ Polymer({
* @private
*/
onClearBrowsingDataTap_: function(e) {
+ md_history.BrowserService.getInstance().recordAction(
+ ['HistoryPage_InitClearBrowsingData']);
md_history.BrowserService.getInstance().openClearBrowsingData();
e.preventDefault();
},
@@ -41,7 +41,5 @@ Polymer({
* @param {Object} route
* @private
*/
- getQueryString_: function(route) {
- return window.location.search;
- }
+ getQueryString_: function(route) { return window.location.search; }
});

Powered by Google App Engine
This is Rietveld 408576698