chrome/test/data/webui/md_history/history_synced_tabs_test.js - Issue 2238163002: [MD History] Add UMA stats for switching views and the CBD button.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/webui/md_history/history_synced_tabs_test.js

Issue 2238163002: [MD History] Add UMA stats for switching views and the CBD button. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@start_focus_in_search_bar

Patch Set: fix_test Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/data/webui/md_history/history_metrics_test.js ('k') | chrome/test/data/webui/md_history/md_history_browsertest.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/webui/md_history/history_synced_tabs_test.js

diff --git a/chrome/test/data/webui/md_history/history_synced_tabs_test.js b/chrome/test/data/webui/md_history/history_synced_tabs_test.js

index 95c9959e72fa3308c5d0cc9abda8581c5473e5db..a78eb08d3dc513b40915f03a49b45bbf6c82630c 100644

--- a/chrome/test/data/webui/md_history/history_synced_tabs_test.js

+++ b/chrome/test/data/webui/md_history/history_synced_tabs_test.js

@@ -53,7 +53,7 @@ cr.define('md_history.history_synced_tabs_test', function() {

setup(function() {

element = document.createElement('history-synced-device-manager');

- element.updateSignInState(true);

+ element.signInState = true;

element.searchTerm = '';

replaceBody(element);

});

@@ -268,10 +268,10 @@ cr.define('md_history.history_synced_tabs_test', function() {

});

test('show sign in promo', function() {

- element.updateSignInState(false);

+ element.signInState = false;

return flush().then(function() {

assertFalse(element.$['sign-in-guide'].hidden);

- element.updateSignInState(true);

+ element.signInState = true;

return flush();

}).then(function() {

assertTrue(element.$['sign-in-guide'].hidden);

@@ -280,7 +280,7 @@ cr.define('md_history.history_synced_tabs_test', function() {

test('no synced tabs message', function() {

// When user is not logged in, there is no synced tabs.

- element.signInState_ = false;

+ element.signInState = false;

element.syncedDevices_ = [];

return flush().then(function() {

assertTrue(element.$['no-synced-tabs'].hidden);

@@ -288,7 +288,7 @@ cr.define('md_history.history_synced_tabs_test', function() {

var cards = getCards(element);

assertEquals(0, cards.length);

- element.updateSignInState(true);

+ element.signInState = true;

return flush();

}).then(function() {

@@ -319,7 +319,7 @@ cr.define('md_history.history_synced_tabs_test', function() {

// If there are any synced tabs, hide the 'no synced tabs' message.

assertTrue(element.$['no-synced-tabs'].hidden);

- element.updateSignInState(false);

+ element.signInState = false;

return flush();

}).then(function() {

// When user signs out, don't show the message.