[MD History] Add UMA stats for switching views and the CBD button.

chrome/browser/resources/md_history/app.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 Polymer({
   is: 'history-app',
 
   properties: {
     showSidebarFooter: Boolean,
 
     // The id of the currently selected page.
-    selectedPage_: {type: String, value: 'history', observer: 'unselectAll'},
+    selectedPage_: {type: String, observer: 'unselectAll'},
 
     // Whether domain-grouped history is enabled.
     grouped_: {type: Boolean, reflectToAttribute: true},
 
     /** @type {!QueryState} */
     queryState_: {
       type: Object,
       value: function() {
         return {
           // Whether the most recent query was incremental.
@@ skipping 46 matching lines @@
   ],
 
   // TODO(calamity): Replace these event listeners with data bound properties.
   listeners: {
     'cr-menu-tap': 'onMenuTap_',
     'history-checkbox-select': 'checkboxSelected',
     'unselect-all': 'unselectAll',
     'delete-selected': 'deleteSelected',
     'search-domain': 'searchDomain_',
     'history-close-drawer': 'closeDrawer_',
+    'history-view-changed': 'recordHistoryView_',
   },
 
   /** @override */
   ready: function() {
     this.grouped_ = loadTimeData.getBoolean('groupByDomain');
 
     cr.ui.decorate('command', cr.ui.Command);
     document.addEventListener('canExecute', this.onCanExecute_.bind(this));
     document.addEventListener('command', this.onCommand_.bind(this));
 
@@ skipping 133 matching lines @@
 
   /**
    * Update sign in state of synced device manager after user logs in or out.
    * @param {boolean} isUserSignedIn
    */
   updateSignInState: function(isUserSignedIn) {
     var syncedDeviceManagerElem =
       /** @type {HistorySyncedDeviceManagerElement} */this
           .$$('history-synced-device-manager');
     if (syncedDeviceManagerElem)
-      syncedDeviceManagerElem.updateSignInState(isUserSignedIn);
+      syncedDeviceManagerElem.signInState = isUserSignedIn;
   },
 
   /**
    * @param {string} selectedPage
    * @return {boolean}
    * @private
    */
   syncedTabsSelected_: function(selectedPage) {
     return selectedPage == 'syncedTabs';
   },
@@ skipping 17 matching lines @@
   routeDataChanged_: function(page) {
     this.selectedPage_ = page;
   },
 
   /**
    * @param {string} selectedPage
    * @private
    */
   selectedPageChanged_: function(selectedPage) {
     this.set('routeData_.page', selectedPage);
+
+    // Log the current view on the next animation frame to allow the iron-pages
+    // to detect that the synced-device-manager has been rendered.
+    requestAnimationFrame(function() {
+      this.recordHistoryView_();
+    }.bind(this));
   },
 
   /**
    * This computed binding is needed to make the iron-pages selector update when
    * the synced-device-manager is instantiated for the first time. Otherwise the
    * fallback selection will continue to be used after the corresponding item is
    * added as a child of iron-pages.
    * @param {string} selectedPage
    * @param {Array} items
    * @return {string}
    * @private
    */
   getSelectedPage_: function(selectedPage, items) {
     return selectedPage;
   },
 
   /** @private */
   closeDrawer_: function() {
     var drawer = this.$$('#drawer');
     if (drawer)
       drawer.close();
   },
+
+  /** @private */
+  recordHistoryView_: function() {
+    var histogramValue = HistoryViewHistogram.END;
+    switch (this.$.content.selectedItem.id) {

[tsergeant, 2016/08/17 06:03:09]

Why not just use this.selectedPage here? Then there's no need for the asyncery
at all.

You can use a default case to handle the fact that 'history' can also be the
empty string.

As an aside, we probably should try to normalise the value in selectedPage_ so
it can't be the empty string.

[calamity, 2016/08/18 03:11:15]

Done. Normalizing sounds... annoying and subtle. I'm not sure how that would
interact with the binding to the route. 

+      case 'history':
+        switch (this.queryState_.range) {
+          case HistoryRange.ALL_TIME:
+            histogramValue = HistoryViewHistogram.HISTORY;
+            break;
+          case HistoryRange.WEEK:
+            histogramValue = HistoryViewHistogram.GROUPED_WEEK;
+            break;
+          case HistoryRange.MONTH:
+            histogramValue = HistoryViewHistogram.GROUPED_MONTH;
+            break;
+        }
+        break;
+      case 'synced-devices':
+        var syncedDeviceManager =
+            /** @type {HistorySyncedDeviceManagerElement} */ this.$.content
+                .selectedItem;
+        histogramValue = syncedDeviceManager.signInState ?
+            HistoryViewHistogram.SYNCED_TABS :
+            HistoryViewHistogram.SIGNIN_PROMO;
+        break;
+    }
+
+    md_history.BrowserService.getInstance().recordHistogram(
+      'History.HistoryView', histogramValue, HistoryViewHistogram.END
+    );
+  },
 });