Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 223813002: Reland "Return MaybeHandle from NewConsString." (Closed)

Created:
6 years, 8 months ago by Yang
Modified:
6 years, 8 months ago
Reviewers:
Igor Sheludko
CC:
v8-dev
Visibility:
Public.

Description

Reland "Return MaybeHandle from NewConsString." R=ishell@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20480

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -88 lines) Patch
M src/api.cc View 2 chunks +7 lines, -8 lines 0 comments Download
M src/factory.h View 2 chunks +7 lines, -2 lines 0 comments Download
M src/factory.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/func-name-inferrer.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M src/handles.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/isolate.h View 1 chunk +1 line, -1 line 0 comments Download
M src/json-stringifier.h View 2 chunks +7 lines, -3 lines 0 comments Download
M src/parser.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M src/runtime.cc View 5 chunks +50 lines, -43 lines 0 comments Download
M src/uri.h View 3 chunks +5 lines, -4 lines 0 comments Download
M test/cctest/test-heap-profiler.cc View 1 chunk +2 lines, -1 line 0 comments Download
M test/cctest/test-strings.cc View 11 chunks +25 lines, -15 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
6 years, 8 months ago (2014-04-03 12:20:08 UTC) #1
Igor Sheludko
lgtm
6 years, 8 months ago (2014-04-03 12:27:29 UTC) #2
Yang
6 years, 8 months ago (2014-04-03 12:31:38 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r20480 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698