Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 2238123004: Remove all but a few spv2 virtual tests (Closed)

Created:
4 years, 4 months ago by pdr.
Modified:
4 years, 4 months ago
Reviewers:
chrishtr, Xianzhu
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove all but a few spv2 virtual tests Per the new slimming paint v2 (spv2) testing plan [1], we will only use virtual tests to catch basic errors on the main CQ. This approach is simpler for the rest of the blink team which may not understand our unique virtual skip-and-pass testing approach. This patch removes all but a few spv2 virtual tests which should catch people completely breaking spv2 but not much more. [1] https://docs.google.com/document/d/1QCM912Dr6u38DqyQqd7pxQxDy8FFOoWMMDq7uAXqKdA/view BUG=601275 Committed: https://crrev.com/07fd19897e1811586bbdcce52a1f331dec3086af Cr-Commit-Position: refs/heads/master@{#411770}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -147 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +0 lines, -147 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
pdr.
4 years, 4 months ago (2016-08-12 20:03:57 UTC) #3
chrishtr
lgtm
4 years, 4 months ago (2016-08-12 20:05:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2238123004/1
4 years, 4 months ago (2016-08-12 20:55:06 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-12 21:15:01 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 21:21:14 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/07fd19897e1811586bbdcce52a1f331dec3086af
Cr-Commit-Position: refs/heads/master@{#411770}

Powered by Google App Engine
This is Rietveld 408576698