Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2238113002: Revert of Enable promotion of RenderPassDrawQuads to CALayers. (Closed)

Created:
4 years, 4 months ago by erikchen
Modified:
4 years, 4 months ago
Reviewers:
ccameron
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Enable promotion of RenderPassDrawQuads to CALayers. (patchset #1 id:1 of https://codereview.chromium.org/2234513002/ ) Reason for revert: Causes performance regressions when there are a lot of filters. Probably needs better IOSurface caching. https://bugs.chromium.org/p/chromium/issues/detail?id=636884 Original issue's description: > Enable promotion of RenderPassDrawQuads to CALayers. > > BUG=581526 > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel > > Committed: https://crrev.com/c48bb2ddd6f847130de7956e9bf7e350d875b10c > Cr-Commit-Position: refs/heads/master@{#411055} TBR=ccameron@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=581526 Committed: https://crrev.com/314269eae868551bb560428fce916863e4d60cb4 Cr-Commit-Position: refs/heads/master@{#411505}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M cc/output/ca_layer_overlay.h View 1 chunk +3 lines, -0 lines 0 comments Download
M cc/output/ca_layer_overlay.cc View 3 chunks +11 lines, -1 line 0 comments Download
M cc/output/overlay_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
erikchen
Created Revert of Enable promotion of RenderPassDrawQuads to CALayers.
4 years, 4 months ago (2016-08-12 00:33:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2238113002/1
4 years, 4 months ago (2016-08-12 00:34:26 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-12 01:19:24 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/314269eae868551bb560428fce916863e4d60cb4 Cr-Commit-Position: refs/heads/master@{#411505}
4 years, 4 months ago (2016-08-12 01:21:41 UTC) #7
erikchen
4 years, 4 months ago (2016-08-16 01:47:48 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2249923003/ by erikchen@chromium.org.

The reason for reverting is: Landing again, since main performance regressions
have been dealt with.

https://bugs.chromium.org/p/chromium/issues/detail?id=636884.

Powered by Google App Engine
This is Rietveld 408576698