net/base/net_util.h - Issue 22381012: Allow p2p UDP packages to set DSCP

Side by Side Diff: net/base/net_util.h

Issue 22381012: Allow p2p UDP packages to set DSCP (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: extra newline removed Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef NET_BASE_NET_UTIL_H_	5 #ifndef NET_BASE_NET_UTIL_H_

6 #define NET_BASE_NET_UTIL_H_	6 #define NET_BASE_NET_UTIL_H_

7	7

8 #include "build/build_config.h"	8 #include "build/build_config.h"

9	9

10 #if defined(OS_WIN)	10 #if defined(OS_WIN)

(...skipping 519 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
530 // 802.11n, HT rates.	530 // 802.11n, HT rates.

531 WIFI_PHY_LAYER_PROTOCOL_N,	531 WIFI_PHY_LAYER_PROTOCOL_N,

532 // Unclassified mode or failure to identify.	532 // Unclassified mode or failure to identify.

533 WIFI_PHY_LAYER_PROTOCOL_UNKNOWN	533 WIFI_PHY_LAYER_PROTOCOL_UNKNOWN

534 };	534 };

535	535

536 // Characterize the PHY mode of the currently associated access point.	536 // Characterize the PHY mode of the currently associated access point.

537 // Currently only available on OS_WIN.	537 // Currently only available on OS_WIN.

538 NET_EXPORT WifiPHYLayerProtocol GetWifiPHYLayerProtocol();	538 NET_EXPORT WifiPHYLayerProtocol GetWifiPHYLayerProtocol();

539	539

	540 // Differentiated Services Code Point, replaces the old IP_TOS flags.

	541 enum DiffServCodePoint {
	Sergey Ulanov 2013/08/17 05:50:04 nit: Is there a better name? code style discourage nit: Is there a better name? code style discourages abbreviations, and this one is hard to understand without searching it up first. Maybe something like IPServiceCode or IPTosLevel? Sergey Ulanov 2013/08/17 05:50:04 net_util.h contains lots of unrelated things. mayb net_util.h contains lots of unrelated things. maybe create a separate header? (though it's up to net owners) hubbe 2013/08/21 18:51:36 I can call it DifferentiatedServicesCodePoint. Add Show quoted text On 2013/08/17 05:50:04, Sergey Ulanov wrote: > nit: Is there a better name? code style discourages abbreviations, and this one > is hard to understand without searching it up first. > Maybe something like IPServiceCode or IPTosLevel? I can call it DifferentiatedServicesCodePoint. Adding link to RFC for more detail. hubbe 2013/08/21 18:51:36 cbenzel, what do you think? Show quoted text On 2013/08/17 05:50:04, Sergey Ulanov wrote: > net_util.h contains lots of unrelated things. maybe create a separate header? > (though it's up to net owners) cbenzel, what do you think? juberti2 2013/08/21 19:13:13 The IETF WG is called "diffserv", so I don't think Show quoted text On 2013/08/21 18:51:36, hubbe wrote: > On 2013/08/17 05:50:04, Sergey Ulanov wrote: > > net_util.h contains lots of unrelated things. maybe create a separate header? > > (though it's up to net owners) > > cbenzel, what do you think? The IETF WG is called "diffserv", so I don't think spelling it out is going to add readability. http://tools.ietf.org/wg/diffserv/ cbentzel 2013/08/21 22:00:20 Agreed, DiffServ is a common abbreviation. Show quoted text On 2013/08/21 19:13:13, juberti2 wrote: > On 2013/08/21 18:51:36, hubbe wrote: > > On 2013/08/17 05:50:04, Sergey Ulanov wrote: > > > net_util.h contains lots of unrelated things. maybe create a separate > header? > > > (though it's up to net owners) > > > > cbenzel, what do you think? > > The IETF WG is called "diffserv", so I don't think spelling it out is going to > add readability. > http://tools.ietf.org/wg/diffserv/ Agreed, DiffServ is a common abbreviation. cbentzel 2013/08/21 22:00:20 net_util.h is (like other _util.h methods) a dumpi Show quoted text On 2013/08/17 05:50:04, Sergey Ulanov wrote: > net_util.h contains lots of unrelated things. maybe create a separate header? > (though it's up to net owners) net_util.h is (like other _util.h methods) a dumping ground for lots of things.
	542 DSCP_NO_CHANGE = -1,
	Sergey Ulanov 2013/08/17 05:50:04 DEFAULT? DEFAULT? hubbe 2013/08/21 18:51:36 Adding DSCP_DEFAULT. (with value 0) Show quoted text On 2013/08/17 05:50:04, Sergey Ulanov wrote: > DEFAULT? Adding DSCP_DEFAULT. (with value 0)
	543 DSCP_CS0 = 0, // The default

	544 DSCP_CS1 = 8, // Bulk/background traffic

	545 DSCP_AF11 = 10,

	546 DSCP_AF12 = 12,

	547 DSCP_AF13 = 14,

	548 DSCP_CS2 = 16,

	549 DSCP_AF21 = 18,

	550 DSCP_AF22 = 20,

	551 DSCP_AF23 = 22,

	552 DSCP_CS3 = 24,

	553 DSCP_AF31 = 26,

	554 DSCP_AF32 = 28,

	555 DSCP_AF33 = 30,

	556 DSCP_CS4 = 32,

	557 DSCP_AF41 = 34, // Video

	558 DSCP_AF42 = 36, // Video

	559 DSCP_AF43 = 38, // Video

	560 DSCP_CS5 = 40, // Video

	561 DSCP_EF = 46, // Voice

	562 DSCP_CS6 = 48, // Voice

	563 DSCP_CS7 = 56, // Control messages

	564 };

	565

	566
	Sergey Ulanov 2013/08/17 05:50:04 nit: remove extra empty line. nit: remove extra empty line. hubbe 2013/08/21 18:51:36 Done. Show quoted text On 2013/08/17 05:50:04, Sergey Ulanov wrote: > nit: remove extra empty line. Done.
540 } // namespace net	567 } // namespace net

541	568

542 #endif // NET_BASE_NET_UTIL_H_	569 #endif // NET_BASE_NET_UTIL_H_

OLD	NEW

« content/renderer/p2p/socket_client.h ('K') | « content/renderer/p2p/socket_client.cc ('k') | net/dns/mock_mdns_socket_factory.h » ('j') | net/udp/datagram_server_socket.h » ('J')