Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 22381003: Add flaky test classification feature to test suites. (Closed)

Created:
7 years, 4 months ago by Michael Achenbach
Modified:
7 years, 4 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Add flaky test classification feature to test suites. Test expectations can now include outcome: FLAKY. The test runner can now run a class of tests (flaky|non-flaky|all). All tests are in the non-flaky class that are not marked as FLAKY. The slash correction for windows is now pulled into the test name method. Currently the progress output on windows contains a mixture of / and \. R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16080

Patch Set 1 : #

Total comments: 3

Patch Set 2 : Review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -23 lines) Patch
M tools/run-tests.py View 1 3 chunks +7 lines, -1 line 0 comments Download
M tools/testrunner/local/old_statusfile.py View 2 chunks +2 lines, -0 lines 0 comments Download
M tools/testrunner/local/statusfile.py View 3 chunks +6 lines, -1 line 0 comments Download
M tools/testrunner/local/testsuite.py View 1 2 chunks +27 lines, -20 lines 0 comments Download
M tools/testrunner/local/verbose.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Michael Achenbach
PTAL
7 years, 4 months ago (2013-08-06 10:01:43 UTC) #1
Jakob Kummerow
LGTM with comments. https://codereview.chromium.org/22381003/diff/5001/tools/run-tests.py File tools/run-tests.py (right): https://codereview.chromium.org/22381003/diff/5001/tools/run-tests.py#newcode97 tools/run-tests.py:97: result.add_option("--classification", "classification" is too generic. How ...
7 years, 4 months ago (2013-08-06 11:11:01 UTC) #2
Michael Achenbach
PTAL. Made some renaming.
7 years, 4 months ago (2013-08-06 12:02:06 UTC) #3
Jakob Kummerow
lgtm
7 years, 4 months ago (2013-08-06 14:30:25 UTC) #4
Michael Achenbach
7 years, 4 months ago (2013-08-06 14:39:45 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r16080 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698