Fixes to get Dart VM compiling on Ubuntu 13.04, Debian Wheezy.

runtime/vm/object.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_OBJECT_H_
 #define VM_OBJECT_H_
 
 #include "include/dart_api.h"
 #include "platform/assert.h"
 #include "platform/utils.h"
@@ skipping 5971 matching lines @@
 
 intptr_t Instance::GetNativeField(Isolate* isolate, int index) const {
   ASSERT(IsValidNativeIndex(index));
   NoGCScope no_gc;
   RawTypedData* native_fields =
       reinterpret_cast<RawTypedData*>(*NativeFieldsAddr());
   if (native_fields == TypedData::null()) {
     return 0;
   }
   intptr_t byte_offset = index * sizeof(intptr_t);
-  return *reinterpret_cast<intptr_t*>(native_fields->ptr()->data_ +
-                                      byte_offset);
+  return *reinterpret_cast<intptr_t*>(
+      reinterpret_cast<intptr_t>(native_fields->ptr()->data_) + byte_offset);

[siva, 2013/08/06 22:53:43]

Please add a comment here as to why the multiple reinterpret_cast is required.

[Chris Bracken, 2013/08/07 06:12:57]

Rewrote with a simpler approach for indexing into RawTypedData's variable-length
data_ that avoids the nested casts and the strict-aliasing warning that came
from dereferencing data_ (uint8_t* cast to intptr_t*)

 }
 
 
 bool String::Equals(const String& str) const {
   if (raw() == str.raw()) {
     return true;  // Both handles point to the same raw instance.
   }
   if (str.IsNull()) {
     return false;
   }
@@ skipping 35 matching lines @@
 
 
 RawObject* MegamorphicCache::GetTargetFunction(const Array& array,
                                                intptr_t index) {
   return array.At((index * kEntryLength) + kTargetFunctionIndex);
 }
 
 }  // namespace dart
 
 #endif  // VM_OBJECT_H_