Video Capture Mojo (1.4b): Implement ability to use fake device instance

services/video_capture/fake_device_video_capture_service_test.h

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef SERVICES_VIDEO_CAPTURE_FAKE_DEVICE_VIDEO_CAPTURE_SERVICE_TEST_H_
+#define SERVICES_VIDEO_CAPTURE_FAKE_DEVICE_VIDEO_CAPTURE_SERVICE_TEST_H_
+
+#include "services/video_capture/video_capture_service_test.h"
+
+namespace video_capture {
+
+// Test fixture that creates a proxy to the fake device provided by the fake
+// device factory.
+class FakeDeviceVideoCaptureServiceTest : public VideoCaptureServiceTest {

[mcasas, 2016/08/31 21:10:35]

Sorry, I meant to put the class declaration & definition
& test cases in a file of its own:
fake_device_video_capture_service_unittest.cc,
containing the usual class declaration+definition (it's
commonplace to inline the SetUp() method) and then
the test cases. Sorry for the confusion :)

[chfremer, 2016/08/31 21:49:43]

No worries. I actually tried that first, but then realized that I need to
separate-out the declarations, because there is a inheritance chain going on
here: FakeDeviceVideoCaptureServiceTest extends VideoCaptureServiceTest. This is
to avoid duplication of the setup code that is common for both.

+ public:
+  FakeDeviceVideoCaptureServiceTest();
+  ~FakeDeviceVideoCaptureServiceTest() override;
+
+  void SetUp() override;
+
+ protected:
+  mojom::VideoCaptureDeviceProxyPtr fake_device_proxy_;
+};
+
+}  // namespace video_capture
+
+#endif  // SERVICES_VIDEO_CAPTURE_FAKE_DEVICE_VIDEO_CAPTURE_SERVICE_TEST_H_