Fix http test

Fix http test

I refactored the code we used in the zero_termination_test to reuse it here,
also moved the test data to be in the same folder as the test.

BUG=

Committed: https://github.com/dart-lang/sdk/commit/8b594e0c2642e425c50f12e07c8258aea8bd4ac4

[Siggi Cherem (dart-lang), 2016-08-12 22:37:11]

sigmund@google.com changed reviewers:
+ sra@google.com, whesse@google.com

[Siggi Cherem (dart-lang), 2016-08-12 22:52:49]

tbr

[Siggi Cherem (dart-lang), 2016-08-12 22:53:21]

Description was changed from

==========
Fix http test

I refactored the code we used in the zero_termination_test to reuse it here,
also moved the test data to be in the same folder as the test.

BUG=
==========

to

==========
Fix http test

I refactored the code we used in the zero_termination_test to reuse it here,
also moved the test data to be in the same folder as the test.

BUG=

Committed:
https://github.com/dart-lang/sdk/commit/8b594e0c2642e425c50f12e07c8258aea8bd4ac4
==========

[Siggi Cherem (dart-lang), 2016-08-12 22:53:23]

Committed patchset #1 (id:1) manually as
8b594e0c2642e425c50f12e07c8258aea8bd4ac4 (presubmit successful).

[eernst, 2016-08-15 13:06:42]

On 2016/08/12 22:53:23, Siggi Cherem (dart-lang) wrote:
> Committed patchset #1 (id:1) manually as
> 8b594e0c2642e425c50f12e07c8258aea8bd4ac4 (presubmit successful).

Just FYI. I guess you already know about this failure, but the information
below might still be relevant for debugging it.

When rebasing a certain CL and checking whether it still worked, I noticed
that http_test.dart was failing. But it isn't caused by my CL, it turns out
to happen in the fresh master branch as well:
https://uberchromegw.corp.google.com/i/client.dart/builders/dart2js-linux-jss...

My local tests indicate that it is exactly the commit of this CL that
introduces the failure.

Adding a couple of printouts (showing `result.stdout` in `check`) revealed
the following in stdout:

----------------------------------------------------------------------
tests/compiler/dart2js/quarantined/http_launch_data/http_launch_main_package.dart:6:1:
Error: Can't read 'package:simple/simple.dart' (Failure getting
http://127.0.0.1:58111/packages/simple/simple.dart: 404 Not Found).
import 'package:simple/simple.dart';
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
tests/compiler/dart2js/quarantined/http_launch_data/http_launch_main_package.dart:9:9:
Warning: Cannot resolve 'foo'.
  print(foo());
        ^^^^^
Error: Compilation failed.
----------------------------------------------------------------------

[Siggi Cherem (dart-lang), 2016-08-15 15:36:25]

On 2016/08/15 13:06:42, eernst wrote:
> On 2016/08/12 22:53:23, Siggi Cherem (dart-lang) wrote:
> > Committed patchset #1 (id:1) manually as
> > 8b594e0c2642e425c50f12e07c8258aea8bd4ac4 (presubmit successful).
> 
> Just FYI. I guess you already know about this failure, but the information
> below might still be relevant for debugging it.
> 
> When rebasing a certain CL and checking whether it still worked, I noticed
> that http_test.dart was failing. But it isn't caused by my CL, it turns out
> to happen in the fresh master branch as well:
>
https://uberchromegw.corp.google.com/i/client.dart/builders/dart2js-linux-jss...
> 
> My local tests indicate that it is exactly the commit of this CL that
> introduces the failure.
> 
> Adding a couple of printouts (showing `result.stdout` in `check`) revealed
> the following in stdout:
> 
> ----------------------------------------------------------------------
>
tests/compiler/dart2js/quarantined/http_launch_data/http_launch_main_package.dart:6:1:
> Error: Can't read 'package:simple/simple.dart' (Failure getting
> http://127.0.0.1:58111/packages/simple/simple.dart: 404 Not Found).
> import 'package:simple/simple.dart';
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>
tests/compiler/dart2js/quarantined/http_launch_data/http_launch_main_package.dart:9:9:
> Warning: Cannot resolve 'foo'.
>   print(foo());
>         ^^^^^
> Error: Compilation failed.
> ----------------------------------------------------------------------

Thanks Erik!

Indeed - I moved a folder (http_launch_data) and in doing so the `packages/`
subfolder was not submitted because `packages` is in excluded by the .gitignore
configuration file. THat's why it was passing for me locally and not remotely.

I'm sending a fix momentarily.