Adding SwiftShader to the DEPS file

Adding SwiftShader to the DEPS file

The SwiftShader library has recently been made open source
and can now be pulled with the Chromium checkout. The size
of the SwiftShader library is roughly 162 Mb, currently.
Note that this will eventually allow us to remove MESA,
which takes approximately 66 Mb, so the net gain should be
under 100Mb in total.

Pulling SwiftShader along with Chromium will allow bots to
build SwiftShader, perform tests with the SwiftShader
library and have quick turnaround time when issues are
found.

This will not change the state of SwiftShader as a
component in Chrome and it will not be shipped with Chrome,
only downloaded as a component on demand.

Also note that this cl does not enable building
SwiftShader, it only allows the SwiftShader library to be
pulled, to make sure that everyone agrees with this first
step.

This is a re-land of https://codereview.chromium.org/2168143003/
after having fixed ozone build breakage (Issue 635702) with
https://codereview.chromium.org/2231913002/

BUG=630728
TBR=jam@chromium.org,phajdan.jr@chromium.org

Change-Id: Iac26a520fffa38410e81f49c666c17e7ceecfbc2
Committed: https://crrev.com/e3976c2e7d2ce17180ebf6d2a576f14c188c843d
Cr-Commit-Position: refs/heads/master@{#411793}

[capn, 2016-08-12 14:43:03]

The CQ bit was checked by capn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-12 14:43:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 15:44:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-12 15:44:27]

Dry run: This issue passed the CQ dry run.

[capn, 2016-08-12 17:48:25]

Description was changed from

==========
Adding SwiftShader to the DEPS file

The SwiftShader library has recently been made open source
and can now be pulled with the Chromium checkout. The size
of the SwiftShader library is roughly 162 Mb, currently.
Note that this will eventually allow us to remove MESA,
which takes approximately 66 Mb, so the net gain should be
under 100Mb in total.

Pulling SwiftShader along with Chromium will allow bots to
build SwiftShader, perform tests with the SwiftShader
library and have quick turnaround time when issues are
found.

This will not change the state of SwiftShader as a
component in Chrome and it will not be shipped with Chrome,
only downloaded as a component on demand.

Also note that this cl does not enable building
SwiftShader, it only allows the SwiftShader library to be
pulled, to make sure that everyone agrees with this first
step.

This is a re-land of https://codereview.chromium.org/2168143003/
after having fixed ozone build breakage (Issue 635702) with
https://codereview.chromium.org/2231913002/

BUG=630728

Change-Id: Iac26a520fffa38410e81f49c666c17e7ceecfbc2
==========

to

==========
Adding SwiftShader to the DEPS file

The SwiftShader library has recently been made open source
and can now be pulled with the Chromium checkout. The size
of the SwiftShader library is roughly 162 Mb, currently.
Note that this will eventually allow us to remove MESA,
which takes approximately 66 Mb, so the net gain should be
under 100Mb in total.

Pulling SwiftShader along with Chromium will allow bots to
build SwiftShader, perform tests with the SwiftShader
library and have quick turnaround time when issues are
found.

This will not change the state of SwiftShader as a
component in Chrome and it will not be shipped with Chrome,
only downloaded as a component on demand.

Also note that this cl does not enable building
SwiftShader, it only allows the SwiftShader library to be
pulled, to make sure that everyone agrees with this first
step.

This is a re-land of https://codereview.chromium.org/2168143003/
after having fixed ozone build breakage (Issue 635702) with
https://codereview.chromium.org/2231913002/

BUG=630728

Change-Id: Iac26a520fffa38410e81f49c666c17e7ceecfbc2
==========

[capn, 2016-08-12 17:48:26]

capn@chromium.org changed reviewers:
+ cpu@chromium.org, jam@chromium.org, kbr@chromium.org, phajdan.jr@chromium.org,
sugoi@chromium.org, tandrii@chromium.org, thestig@chromium.org

[capn, 2016-08-12 17:48:45]

PTAL

This is a re-land of https://codereview.chromium.org/2168143003/
after having fixed ozone build breakage (Issue 635702) with
https://codereview.chromium.org/2231913002/

[tandrii(chromium), 2016-08-12 17:50:05]

LGTM

[Ken Russell (switch to Gerrit), 2016-08-12 17:54:16]

lgtm

[capn, 2016-08-12 20:10:40]

The CQ bit was checked by capn@chromium.org

[commit-bot: I haz the power, 2016-08-12 20:11:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 20:18:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-12 20:18:07]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[capn, 2016-08-12 20:40:00]

Description was changed from

==========
Adding SwiftShader to the DEPS file

The SwiftShader library has recently been made open source
and can now be pulled with the Chromium checkout. The size
of the SwiftShader library is roughly 162 Mb, currently.
Note that this will eventually allow us to remove MESA,
which takes approximately 66 Mb, so the net gain should be
under 100Mb in total.

Pulling SwiftShader along with Chromium will allow bots to
build SwiftShader, perform tests with the SwiftShader
library and have quick turnaround time when issues are
found.

This will not change the state of SwiftShader as a
component in Chrome and it will not be shipped with Chrome,
only downloaded as a component on demand.

Also note that this cl does not enable building
SwiftShader, it only allows the SwiftShader library to be
pulled, to make sure that everyone agrees with this first
step.

This is a re-land of https://codereview.chromium.org/2168143003/
after having fixed ozone build breakage (Issue 635702) with
https://codereview.chromium.org/2231913002/

BUG=630728

Change-Id: Iac26a520fffa38410e81f49c666c17e7ceecfbc2
==========

to

==========
Adding SwiftShader to the DEPS file

The SwiftShader library has recently been made open source
and can now be pulled with the Chromium checkout. The size
of the SwiftShader library is roughly 162 Mb, currently.
Note that this will eventually allow us to remove MESA,
which takes approximately 66 Mb, so the net gain should be
under 100Mb in total.

Pulling SwiftShader along with Chromium will allow bots to
build SwiftShader, perform tests with the SwiftShader
library and have quick turnaround time when issues are
found.

This will not change the state of SwiftShader as a
component in Chrome and it will not be shipped with Chrome,
only downloaded as a component on demand.

Also note that this cl does not enable building
SwiftShader, it only allows the SwiftShader library to be
pulled, to make sure that everyone agrees with this first
step.

This is a re-land of https://codereview.chromium.org/2168143003/
after having fixed ozone build breakage (Issue 635702) with
https://codereview.chromium.org/2231913002/

BUG=630728
TBR=jam@chromium.org,phajdan.jr@chromium.org

Change-Id: Iac26a520fffa38410e81f49c666c17e7ceecfbc2
==========

[capn, 2016-08-12 20:40:08]

The CQ bit was checked by capn@chromium.org

[capn, 2016-08-12 20:40:08]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org,
tandrii@chromium.org
Link to the patchset: https://codereview.chromium.org/2238063003/#ps20001
(title: "Add TBRs for previous approvals.")

[commit-bot: I haz the power, 2016-08-12 20:40:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 22:06:33]

Description was changed from

==========
Adding SwiftShader to the DEPS file

The SwiftShader library has recently been made open source
and can now be pulled with the Chromium checkout. The size
of the SwiftShader library is roughly 162 Mb, currently.
Note that this will eventually allow us to remove MESA,
which takes approximately 66 Mb, so the net gain should be
under 100Mb in total.

Pulling SwiftShader along with Chromium will allow bots to
build SwiftShader, perform tests with the SwiftShader
library and have quick turnaround time when issues are
found.

This will not change the state of SwiftShader as a
component in Chrome and it will not be shipped with Chrome,
only downloaded as a component on demand.

Also note that this cl does not enable building
SwiftShader, it only allows the SwiftShader library to be
pulled, to make sure that everyone agrees with this first
step.

This is a re-land of https://codereview.chromium.org/2168143003/
after having fixed ozone build breakage (Issue 635702) with
https://codereview.chromium.org/2231913002/

BUG=630728
TBR=jam@chromium.org,phajdan.jr@chromium.org

Change-Id: Iac26a520fffa38410e81f49c666c17e7ceecfbc2
==========

to

==========
Adding SwiftShader to the DEPS file

The SwiftShader library has recently been made open source
and can now be pulled with the Chromium checkout. The size
of the SwiftShader library is roughly 162 Mb, currently.
Note that this will eventually allow us to remove MESA,
which takes approximately 66 Mb, so the net gain should be
under 100Mb in total.

Pulling SwiftShader along with Chromium will allow bots to
build SwiftShader, perform tests with the SwiftShader
library and have quick turnaround time when issues are
found.

This will not change the state of SwiftShader as a
component in Chrome and it will not be shipped with Chrome,
only downloaded as a component on demand.

Also note that this cl does not enable building
SwiftShader, it only allows the SwiftShader library to be
pulled, to make sure that everyone agrees with this first
step.

This is a re-land of https://codereview.chromium.org/2168143003/
after having fixed ozone build breakage (Issue 635702) with
https://codereview.chromium.org/2231913002/

BUG=630728
TBR=jam@chromium.org,phajdan.jr@chromium.org

Change-Id: Iac26a520fffa38410e81f49c666c17e7ceecfbc2
==========

[commit-bot: I haz the power, 2016-08-12 22:06:34]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-12 22:07:42]

Description was changed from

==========
Adding SwiftShader to the DEPS file

The SwiftShader library has recently been made open source
and can now be pulled with the Chromium checkout. The size
of the SwiftShader library is roughly 162 Mb, currently.
Note that this will eventually allow us to remove MESA,
which takes approximately 66 Mb, so the net gain should be
under 100Mb in total.

Pulling SwiftShader along with Chromium will allow bots to
build SwiftShader, perform tests with the SwiftShader
library and have quick turnaround time when issues are
found.

This will not change the state of SwiftShader as a
component in Chrome and it will not be shipped with Chrome,
only downloaded as a component on demand.

Also note that this cl does not enable building
SwiftShader, it only allows the SwiftShader library to be
pulled, to make sure that everyone agrees with this first
step.

This is a re-land of https://codereview.chromium.org/2168143003/
after having fixed ozone build breakage (Issue 635702) with
https://codereview.chromium.org/2231913002/

BUG=630728
TBR=jam@chromium.org,phajdan.jr@chromium.org

Change-Id: Iac26a520fffa38410e81f49c666c17e7ceecfbc2
==========

to

==========
Adding SwiftShader to the DEPS file

The SwiftShader library has recently been made open source
and can now be pulled with the Chromium checkout. The size
of the SwiftShader library is roughly 162 Mb, currently.
Note that this will eventually allow us to remove MESA,
which takes approximately 66 Mb, so the net gain should be
under 100Mb in total.

Pulling SwiftShader along with Chromium will allow bots to
build SwiftShader, perform tests with the SwiftShader
library and have quick turnaround time when issues are
found.

This will not change the state of SwiftShader as a
component in Chrome and it will not be shipped with Chrome,
only downloaded as a component on demand.

Also note that this cl does not enable building
SwiftShader, it only allows the SwiftShader library to be
pulled, to make sure that everyone agrees with this first
step.

This is a re-land of https://codereview.chromium.org/2168143003/
after having fixed ozone build breakage (Issue 635702) with
https://codereview.chromium.org/2231913002/

BUG=630728
TBR=jam@chromium.org,phajdan.jr@chromium.org

Change-Id: Iac26a520fffa38410e81f49c666c17e7ceecfbc2
Committed: https://crrev.com/e3976c2e7d2ce17180ebf6d2a576f14c188c843d
Cr-Commit-Position: refs/heads/master@{#411793}
==========

[commit-bot: I haz the power, 2016-08-12 22:07:43]

Patchset 2 (id:??) landed as
https://crrev.com/e3976c2e7d2ce17180ebf6d2a576f14c188c843d
Cr-Commit-Position: refs/heads/master@{#411793}

[Torne, 2016-08-15 17:35:16]

torne@chromium.org changed reviewers:
+ torne@chromium.org

[Torne, 2016-08-15 17:35:17]

Hi; you added third_party/swiftshader to DEPS, but there are still files in
third_party/swiftshader in the main repository as well (README.chromium and
LICENSE).

This causes git to behave very badly, as both git repositories will be trying to
manage the contents of the directory: they'll both think that files
added/removed by the other side are new/missing.

Please fix this; this is likely to lead to a number of weird problems. In other
cases where we need to add additional files to a DEPS'ed-in project, the DEPS
checks it out into a subdirectory under third_party/foo so that the main repo
can safely contain other files in third_party/foo.

[capn, 2016-08-15 17:52:24]

On 2016/08/15 17:35:17, Torne wrote:
> Hi; you added third_party/swiftshader to DEPS, but there are still files in
> third_party/swiftshader in the main repository as well (README.chromium and
> LICENSE).
> 
> This causes git to behave very badly, as both git repositories will be trying
to
> manage the contents of the directory: they'll both think that files
> added/removed by the other side are new/missing.
> 
> Please fix this; this is likely to lead to a number of weird problems. In
other
> cases where we need to add additional files to a DEPS'ed-in project, the DEPS
> checks it out into a subdirectory under third_party/foo so that the main repo
> can safely contain other files in third_party/foo.

Yes, I'm currently trying to figure out where those two files originate from:
https://codereview.chromium.org/2224093003/
They are untracked and when I delete them and repo sync they're still gone, but
a fetch chromium creates them...

Do you happen to know how I can get rid of them? They're no longer needed now
that SwiftShader is open-source.

[capn, 2016-08-15 17:58:22]

On 2016/08/15 17:52:24, capn wrote:
> Do you happen to know how I can get rid of them? They're no longer needed now
> that SwiftShader is open-source.

Found them:
https://chromium.googlesource.com/chromium/src/+/master/third_party/swiftshader/

Still odd they're untracked...

[Torne, 2016-08-15 18:30:31]

They exist in the src repo. You need to delete them while in "src" (not in
third_party/swiftshader which is a different repo) and then land that
directly as a chromium src change (the commit queue will probably not
work). If this is the correct thing to do and you can't get it to work I
can do it for you.

They are untracked *by the other repository*; if you see them as untracked
you are running git from the wrong place :)

On Mon, 15 Aug 2016, 6:52 pm , <capn@chromium.org> wrote:

> On 2016/08/15 17:35:17, Torne wrote:
> > Hi; you added third_party/swiftshader to DEPS, but there are still files
> in
> > third_party/swiftshader in the main repository as well (README.chromium
> and
> > LICENSE).
> >
> > This causes git to behave very badly, as both git repositories will be
> trying
> to
> > manage the contents of the directory: they'll both think that files
> > added/removed by the other side are new/missing.
> >
> > Please fix this; this is likely to lead to a number of weird problems. In
> other
> > cases where we need to add additional files to a DEPS'ed-in project, the
> DEPS
> > checks it out into a subdirectory under third_party/foo so that the main
> repo
> > can safely contain other files in third_party/foo.
>
> Yes, I'm currently trying to figure out where those two files originate
> from:
> https://codereview.chromium.org/2224093003/
> They are untracked and when I delete them and repo sync they're still
> gone, but
> a fetch chromium creates them...
>
> Do you happen to know how I can get rid of them? They're no longer needed
> now
> that SwiftShader is open-source.
>
> https://codereview.chromium.org/2238063003/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[santosrudy0586, 2017-05-26 17:05:44]

santosrudy0586@gmail.com changed reviewers:
+ santosrudy0586@gmail.com

[santosrudy0586, 2017-05-26 17:05:45]

Haloo selamat mlmfwdaflhhm93rg8w4ws8004gokkw8@rudy1.bitrix24.com

[santosrudy0586, 2017-05-26 17:09:33]

On 2017/05/26 17:05:45, santosrudy0586 wrote:
> Haloo selamat mailto:mlmfwdaflhhm93rg8w4ws8004gokkw8@rudy1.bitrix24.com

2238063003https://codetrvirew.chromium.org