Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Issue 2238043002: Fix multiple test result printing and rebaseline compositing/video/video-reflection.html (Closed)

Created:
4 years, 4 months ago by Stephen Chennney
Modified:
4 years, 4 months ago
Reviewers:
ajuma, pdr.
CC:
chromium-reviews, blink-reviews, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix multiple test result printing and rebaseline compositing/video/video-reflection.html This test seems to be working fine, except for the fact that it prints out the test result for every frame (it seems) and the image is slightly different now. This patch modifies the test to only act on the first seek callback, and set the image for rebaselining. R=ajuma@chromium.org,pdr@chromium.org BUG=324370, 636475 Committed: https://crrev.com/af0799c558d7baf6de53392287ee3af78b90e2d4 Cr-Commit-Position: refs/heads/master@{#412313}

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -5 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/compositing/video/video-reflection.html View 2 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 20 (12 generated)
Stephen Chennney
PTAL
4 years, 4 months ago (2016-08-11 20:58:02 UTC) #2
Stephen Chennney
Chose a non-owner reviewer, so choosing new victims for review.
4 years, 4 months ago (2016-08-15 15:55:48 UTC) #8
ajuma
lgtm
4 years, 4 months ago (2016-08-15 16:52:43 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2238043002/1
4 years, 4 months ago (2016-08-15 16:54:30 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/251290) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 4 months ago (2016-08-15 16:57:05 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2238043002/20001
4 years, 4 months ago (2016-08-16 18:51:48 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-16 20:02:17 UTC) #18
commit-bot: I haz the power
4 years, 4 months ago (2016-08-16 20:03:54 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/af0799c558d7baf6de53392287ee3af78b90e2d4
Cr-Commit-Position: refs/heads/master@{#412313}

Powered by Google App Engine
This is Rietveld 408576698