Issue 223803003: [DevTools] Switch from insets to bounds to position inspected page.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 223803003: [DevTools] Switch from insets to bounds to position inspected page. (Closed)

Created:
6 years, 8 months ago by dgozman

Modified:
6 years, 7 months ago

Reviewers:
pfeldman

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

[DevTools] Switch from insets to bounds to position inspected page. BUG=373669 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174361

Patch Set 1 #

Patch Set 2 : rebased #

Patch Set 3 : rebase #

Patch Set 4 : #

Patch Set 5 : rebase #

Patch Set 6 : rebased #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -48 lines)			Patch
M	Source/devtools/front_end/InspectorFrontendHostStub.js	View	1 2 3 4	1 chunk	+8 lines, -0 lines	0 comments	Download
M	Source/devtools/front_end/externs.js	View	1 2 3 4	1 chunk	+5 lines, -0 lines	0 comments	Download
M	Source/devtools/front_end/ui/InspectedPagePlaceholder.js	View	1 2	5 chunks	+21 lines, -48 lines	0 comments	Download
M	Source/web/InspectorFrontendClientImpl.cpp	View	1 2 3 4	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

dgozman

Take a look please. Chrome-side: https://codereview.chromium.org/221283009/.

6 years, 7 months ago (2014-05-15 09:41:17 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/223803003/100001

6 years, 7 months ago (2014-05-20 08:32:55 UTC) #4

Message was sent while issue was closed.

Change committed as 174361

Expand Messages | Collapse Messages