Issue 2238006: Use DBUS_FATAL_WARNINGS=0 environment variable on Chrome just like as Ubuntu.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2238006: Use DBUS_FATAL_WARNINGS=0 environment variable on Chrome just like as Ubuntu. (Closed)

Created:
10 years, 7 months ago by Yusuke Sato

Modified:
9 years, 7 months ago

Reviewers:
Chris Masone

CC:
chromium-os-reviews_chromium.org, satorux1, James Su, Zachary Kuznia, mazda

Base URL:
ssh://git@gitrw.chromium.org//login_manager.git

Visibility:
Public.

Description

Use DBUS_FATAL_WARNINGS=0 environment variable on Chrome just like Ubuntu. See http://crosbug.com/3596 for details. BUG=chromium-os:3596 TEST=verified that /proc/<pid_for_chrome>/environ has the variable.

Patch Set 1 #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	session_manager_setup.sh	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Yusuke Sato

Chris, can you please review this? I believe this change is useful for components that ...

10 years, 7 months ago (2010-05-27 11:25:02 UTC) #1

Chris Masone

10 years, 7 months ago (2010-05-27 14:03:08 UTC) #2

LGTM

On Thu, May 27, 2010 at 4:25 AM,  <yusukes@chromium.org> wrote:
> Reviewers: cmasone,
>
> Message:
> Chris, can you please review this?
> I believe this change is useful for components that use DBus.
>
>
>
> Description:
> Use DBUS_FATAL_WARNINGS=0 environment variable on Chrome just like as
> Ubuntu.
> See http://crosbug.com/3596 for details.
>
> BUG=chromium-os:3596
> TEST=verified that /proc/<pid_for_chrome>/environment has the variable.
>
> Please review this at http://codereview.chromium.org/2238006/show
>
> SVN Base: ssh://git@gitrw.chromium.org//login_manager.git
>
> Affected files:
>  M session_manager_setup.sh
>
>
> Index: session_manager_setup.sh
> diff --git a/session_manager_setup.sh b/session_manager_setup.sh
> index
>
8c97c0fc6e2409f17981467d9a1e2657680ab17d..5351a8e902295ace114b42223cc5295b22303377
> 100755
> --- a/session_manager_setup.sh
> +++ b/session_manager_setup.sh
> @@ -28,6 +28,8 @@ export HOME=${DATA_DIR}/user
>  export DISPLAY=:0.0
>  export PATH=/bin:/usr/bin:/usr/local/bin:/usr/bin/X11
>  export GTK_IM_MODULE=ibus
> +# By default, libdbus treats all warnings as fatal errors. That's too
> strict.
> +export DBUS_FATAL_WARNINGS=0
>
>  # Uncomment this to turn on chrome logs.
>  # They will be be output to /home/chrome/chrome_log
>
>
>

Expand Messages | Collapse Messages