Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Unified Diff: third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/watch-expressions-preserve-expansion.html

Issue 2238003002: DevTools: migrate sources panel sidebar to views. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: followed up on the watch test. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/watch-expressions-preserve-expansion.html
diff --git a/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/watch-expressions-preserve-expansion.html b/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/watch-expressions-preserve-expansion.html
index ffaf00013d1ecd2204dbffea85e19a831a9a7470..424444ea397a331bdbc00d9b436bb30090b01d45 100644
--- a/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/watch-expressions-preserve-expansion.html
+++ b/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/watch-expressions-preserve-expansion.html
@@ -26,13 +26,16 @@ for (var i = 0; i < 300; ++i)
var test = function()
{
- var watchExpressionsPane = WebInspector.panels.sources.sidebarPanes.watchExpressions;
- watchExpressionsPane.revealView();
- watchExpressionsPane.addExpression("globalObject");
- watchExpressionsPane.addExpression("windowAlias");
- watchExpressionsPane.addExpression("array");
- watchExpressionsPane.addExpression("func");
- InspectorTest.deprecatedRunAfterPendingDispatches(step2);
+ var watchExpressionsPane = self.runtime.sharedInstance(WebInspector.WatchExpressionsSidebarPane);
+ WebInspector.panels.sources._sidebarPaneStack.showView(WebInspector.panels.sources._watchSidebarPane).then(() => {
+ watchExpressionsPane.doUpdate();
+ watchExpressionsPane._createWatchExpression("globalObject");
+ watchExpressionsPane._createWatchExpression("windowAlias");
+ watchExpressionsPane._createWatchExpression("array");
+ watchExpressionsPane._createWatchExpression("func");
+ watchExpressionsPane._saveExpressions();
+ InspectorTest.deprecatedRunAfterPendingDispatches(step2);
+ });
function step2()
{
@@ -58,7 +61,7 @@ var test = function()
function dumpWatchExpressions()
{
- var pane = WebInspector.panels.sources.sidebarPanes.watchExpressions;
+ var pane = self.runtime.sharedInstance(WebInspector.WatchExpressionsSidebarPane);
for (var i = 0; i < pane._watchExpressions.length; i++) {
var watch = pane._watchExpressions[i];
@@ -105,7 +108,7 @@ var test = function()
function expandWatchExpression(path, callback)
{
- var pane = WebInspector.panels.sources.sidebarPanes.watchExpressions;
+ var pane = self.runtime.sharedInstance(WebInspector.WatchExpressionsSidebarPane);
var expression = path.shift();
for (var i = 0; i < pane._watchExpressions.length; i++) {
var watch = pane._watchExpressions[i];

Powered by Google App Engine
This is Rietveld 408576698