third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/error-in-watch-expressions.html - Issue 2238003002: DevTools: migrate sources panel sidebar to views.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/error-in-watch-expressions.html

Issue 2238003002: DevTools: migrate sources panel sidebar to views. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: followed up on the watch test. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/http/tests/inspector/debugger-test.js ('K') | « third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/debugger-expand-scope.html ('k') | third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/reveal-not-skipped-expected.txt » ('j') | third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/watch-expressions-panel-switch.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/error-in-watch-expressions.html

diff --git a/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/error-in-watch-expressions.html b/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/error-in-watch-expressions.html

index 1b48d8b0e5b0c3f5d3dfa224bd217a2ad240bb05..2c33e118df74d75a191c5badd5c6b1ebb8598d27 100644

--- a/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/error-in-watch-expressions.html

+++ b/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/error-in-watch-expressions.html

@@ -7,11 +7,14 @@ var foo = 123

var test = function()

{

- var watchExpressionsPane = WebInspector.panels.sources.sidebarPanes.watchExpressions;

- watchExpressionsPane.revealView();

- watchExpressionsPane.addExpression("#$%");

+ var watchExpressionsPane = self.runtime.sharedInstance(WebInspector.WatchExpressionsSidebarPane);

+ WebInspector.panels.sources._sidebarPaneStack.showView(WebInspector.panels.sources._watchSidebarPane).then(() => {

+ watchExpressionsPane.doUpdate();

+ watchExpressionsPane._createWatchExpression("#$%");

+ watchExpressionsPane._saveExpressions();

+ InspectorTest.deprecatedRunAfterPendingDispatches(step1);

+ });

- InspectorTest.deprecatedRunAfterPendingDispatches(step1);

function step1()

{