DevTools: migrate sources panel sidebar to views.

third_party/WebKit/Source/devtools/front_end/ui/View.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @interface
  */
 WebInspector.View = function()
 {
 }
@@ skipping 284 matching lines @@
 
     for (var extension of self.runtime.extensions("view")) {
         var descriptor = extension.descriptor();
         this._views.set(descriptor["id"], new WebInspector.ProvidedView(extension));
         this._locationNameByViewId.set(descriptor["id"], descriptor["location"]);
     }
 }
 
 WebInspector.ViewManager.prototype = {
     /**
-     * @param {!WebInspector.Widget} widget
-     */
-    revealViewWithWidget: function(widget)
-    {
-        var view = widget[WebInspector.View._symbol];
-        if (view)
-            this.revealView(view);
-    },
-
-    /**
      * @param {!WebInspector.View} view
      * @return {!Promise}
      */
     revealView: function(view)
     {
         var location = /** @type {?WebInspector.ViewManager._Location} */ (view[WebInspector.ViewManager._Location.symbol]);
         if (!location)
             return Promise.resolve();
         location._reveal();
         return location.showView(view);
     },
 
     /**
      * @param {string} viewId
+     * @return {?WebInspector.View}
+     */
+    view: function(viewId)
+    {
+        return this._views.get(viewId);
+    },
+
+    /**
+     * @param {string} viewId
      * @return {!Promise}
      */
     showView: function(viewId)
     {
         var view = this._views.get(viewId);
         if (!view) {
             console.error("Could not find view for id: '" + viewId + "' " + new Error().stack);
             return Promise.resolve();
         }
+
         var locationName = this._locationNameByViewId.get(viewId);
         if (locationName === "drawer-view")
             WebInspector.userMetrics.drawerShown(viewId);
 
+        var location = view[WebInspector.ViewManager._Location.symbol];
+        if (location) {
+            location._reveal();
+            return location.showView(view);
+        }
+
         return this._resolveLocation(locationName).then(location => {
             if (!location)
-                return;
+                throw new Error("Could not resolve location for view: " + viewId);
             location._reveal();
             return location.showView(view);
         });
     },
 
     /**
      * @param {string=} location
      * @return {!Promise<?WebInspector.ViewManager._Location>}
      */
     _resolveLocation: function(location)
@@ skipping 310 matching lines @@
      * @override
      * @param {!WebInspector.View} view
      * @param {?WebInspector.View=} insertBefore
      */
     appendView: function(view, insertBefore)
     {
         if (insertBefore)
             throw new Error("Insert before in tabbed pane is not supported");
         if (!this._tabbedPane.hasTab(view.viewId())) {
             view[WebInspector.ViewManager._Location.symbol] = this;
+            this._manager._views.set(view.viewId(), view);
             this._views.set(view.viewId(), view);
             this._appendTab(view);
         }
     },
 
     /**
      * @override
      * @param {!WebInspector.View} view
      * @param {?WebInspector.View=} insertBefore
      * @return {!Promise}
@@ skipping 80 matching lines @@
     /**
      * @override
      * @param {!WebInspector.View} view
      * @param {?WebInspector.View=} insertBefore
      */
     appendView: function(view, insertBefore)
     {
         var container = this._expandableContainers.get(view.viewId());
         if (!container) {
             view[WebInspector.ViewManager._Location.symbol] = this;
+            this._manager._views.set(view.viewId(), view);
             container = new WebInspector.ViewManager._ExpandableContainerWidget(view);
             var beforeElement = null;
             if (insertBefore) {
                 var beforeContainer = insertBefore[WebInspector.ViewManager._ExpandableContainerWidget._symbol];
                 beforeElement = beforeContainer ? beforeContainer.element : null;
             }
             container.show(this._vbox.contentElement, beforeElement);
             this._expandableContainers.set(view.viewId(), container);
         }
     },
@@ skipping 21 matching lines @@
             this.appendView(view);
     },
 
     __proto__: WebInspector.ViewManager._Location.prototype
 }
 
 /**
  * @type {!WebInspector.ViewManager}
  */
 WebInspector.viewManager;